expect('#selector.without_$').toJustWork() -- revised #54

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pmcelhaney

Thanks for the feedback on my last pull request. I see that it broke the toBe() matcher. We want

 expect('just a string').toBe('just a string'); 

to fall back to the built-in matcher rather than treating 'just a string' like it's a jQuery selector. I think I solved the problem by just not having my shortcut apply to matchers that override built-in matchers.

Patrick McElhaney expect('#selector.without_$').toJustWork()*
* unless we're overriding a built-in matcher
e85f0eb
@travisjeffery
Collaborator

Having played around with this more I'm not going to merge it in. I tried it out on another project with a much more extensive test suite and had some broken tests and getting this to work is causes too much technical debt from trying to cover all these cases.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment