slide of image (carousel) added in the assets dialog admin-ui panel #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 30, 2023 11:27
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
|
Hi! Just wanted to let you know I saw this and will properly review later this week. |
michaelbromley
requested changes
Sep 6, 2023
| asset: AssetLike; | ||
| assets: AssetLike[]; |
There was a problem hiding this comment.
Let's mark this as optional in case anyone already uses this component before this change, they won't be passing in the locals: { assets } array.
| @@ -46,6 +48,8 @@ export class AssetPreviewDialogComponent implements Dialog<void>, OnInit { | |||
| } | |||
| }), | |||
| ); | |||
|
|
|||
| this.assetsWithTags$ = of(this.assets); | |||
There was a problem hiding this comment.
Likewise this would then be changed to
of(this.assets ?? [])| assetChanges?: UpdateAssetInput; | ||
| resolveWith: (result?: void) => void; | ||
| assetWithTags$: Observable<GetAssetQuery['asset']>; | ||
| assetsWithTags$; |
There was a problem hiding this comment.
This needs a type:
assetsWithTags$: Observable<Array<GetAssetQuery['asset']>>;| @@ -33,6 +33,7 @@ export type PreviewPreset = 'tiny' | 'thumb' | 'small' | 'medium' | 'large' | '' | |||
| }) | |||
| export class AssetPreviewComponent implements OnInit, OnDestroy { | |||
| @Input() asset: AssetLike; | |||
| @Input() assets: AssetLike[]; | |||
There was a problem hiding this comment.
mark this as optional since existing external uses of the component will not be passing it.
@Input() assets?: AssetLike[];
|
Hi!! |
|
Thanks for your help on this! 🙏 🥳 |
michaelbromley
pushed a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented a generalized solution where we have a number of assets which can be opened in the dialog from:
product detail view
product variant detail view
collection detail view
asset list view