Skip to content

Small, stylistic changes#1

Merged
soffes merged 6 commits into
venmo:masterfrom
stephencelis:small-changes
Jun 23, 2015
Merged

Small, stylistic changes#1
soffes merged 6 commits into
venmo:masterfrom
stephencelis:small-changes

Conversation

@stephencelis
Copy link
Copy Markdown
Contributor

Happy to drop any of the commits or the PR entirely. Was just reading the code and found a few spots that could become shorter and less mutable without hurting readability.

Comment thread DVR/Cassette.swift
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh who knew?! Is this new?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this since day 1. I love trailing closure syntax. 🎉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize the () were optional if you did that. So great.

soffes added a commit that referenced this pull request Jun 23, 2015
@soffes soffes merged commit 69e50e2 into venmo:master Jun 23, 2015
@soffes
Copy link
Copy Markdown
Contributor

soffes commented Jun 23, 2015

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@venmo venmo locked and limited conversation to collaborators Jun 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants