Remove reference to functions as selections

[eliperkins]

This was causing memory leaks as the closure referenced self, without declaring it's ownership of self.
From the Swift docs: "A strong reference cycle can also occur if you assign a closure to a property of a
class instance, and the body of that closure captures the instance...[this] strong reference cycle occurs
because closures, like classes, are reference types"

By adding the [unowned self] to each selection, we remove any retain cycles.

[ayanonagon]

We put this line on the same line as the opening brace in our app. I don’t really mind whichever way, but we should be consistent ✨

[eliperkins]

Fixed!

[ayanonagon]

Yay! Thanks for this, and the reference to the Swift docs.

Wanna update the README too so other people don’t run into the same issues that we did? :D

[ayanonagon]

🍏

[eliperkins]

@ayanonagon Is there something specific in the README that you think should get updated?

[ayanonagon]

Section(header: "Money", rows: [
    Row(text: "Balance", detailText: "$12.00", accessory: .DisclosureIndicator, selection: {
        // Show statement
    }),
    Row(text: "Transfer to Bank…", cellClass: ButtonCell.self, selection: {
        // Show transfer to bank modal
    })
], footer: "Transfers usually arrive within 1-3 business days.")

I guess that doesn’t reference self but might be nice to show an example of it.

[eliperkins]

@ayanonagon How's that? 812f8d3

[hyperspacemark]

It's minor but would you mind putting that example of presenting a view controller in the transfer to bank row instead?

[eliperkins]

@hyperspacemark done.

[ayanonagon]

🍏