Merge pull request #45 from venmo/daz/no_signed_request

If no signed request is returned, create an incomplete transaction error
venmo · Sep 4, 2014 · 1062baa · 1062baa
2 parents e111d50 + c0210f2
commit 1062baa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/venmo-sdk/Supporting Files/VENErrors.h b/venmo-sdk/Supporting Files/VENErrors.h
@@ -7,6 +7,8 @@ typedef enum VENSDKErrorCode {
     VENSDKErrorTransactionValidationError = 1,
     // Venmo server failed to complete transaction
     VENSDKErrorTransactionFailed,
+    // Client did not return a signed request
+    VENSDKErrorTransactionIncomplete,
     // Non-success HTTP status code was returned
     VENSDKErrorHTTPError,
     // An error occurred related to Venmo OAuth

diff --git a/venmo-sdk/URL Handling/VENURLProtocol.m b/venmo-sdk/URL Handling/VENURLProtocol.m
@@ -115,6 +115,12 @@ - (void)startLoading {
                                       description:@"Failed to validate the transaction."
                                recoverySuggestion:@"Please contact us."];
             }
+            else if (!transaction) {
+                error  = [NSError errorWithDomain:VenmoSDKDomain
+                                             code:VENSDKErrorTransactionIncomplete
+                                      description:@"The transaction was incomplete."
+                               recoverySuggestion:@"Please try again."];
+            }
 
             if ([Venmo sharedInstance].transactionCompletionHandler) {
                 [Venmo sharedInstance].transactionCompletionHandler(transaction, transaction.status, error);