Skip to content

Add spec for missing #replace_fields scenario #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2017
Merged

Add spec for missing #replace_fields scenario #59

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9b778d
Add scenario for missing `replace_<type>?` policy action on
gnfisher Apr 7, 2017
e7fc0b3
Rearrange specs for replace_fields and add coverage
gnfisher Apr 12, 2017
fdbcff7
Remove whitespace
gnfisher Apr 12, 2017
4d947a8
Fix spec, dont expect specific error not to be raised
gnfisher Apr 13, 2017
3fce596
Fix too specific not_to raise_error assert
valscion Apr 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions spec/jsonapi/authorization/default_pundit_authorizer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,44 +168,51 @@
records: related_records
}]
end

subject(:method_call) do
-> { authorizer.replace_fields(source_record, related_records_with_context) }
end

context 'authorized for update? on source record' do
context 'authorized for update? on source record and related records is empty' do
before { allow_action(source_record, 'update?') }
let(:related_records) { [] }
it { is_expected.not_to raise_error }
end

context 'related records is empty' do
let(:related_records) { [] }
it { is_expected.not_to raise_error }
end
context 'unauthorized for update? on source record and related records is empty' do
before { disallow_action(source_record, 'update?') }
let(:related_records) { [] }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end

context 'authorized for replace_comments? on source record' do
before { stub_policy_actions(source_record, replace_comments?: true, update?: true) }
it { is_expected.not_to raise_error(::Pundit::NotAuthorizedError) }
end
context 'authorized for replace_comments? and authorized for update? on source record' do
before { stub_policy_actions(source_record, replace_comments?: true, update?: true) }
it { is_expected.not_to raise_error }
end

context 'unauthorized for replace_comments? on source record' do
before { stub_policy_actions(source_record, replace_comments?: false, update?: true) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end
context 'unauthorized for replace_comments? and authorized for update? on source record' do
before { stub_policy_actions(source_record, replace_comments?: false, update?: true) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end

context 'unauthorized for update? on source record' do
before { disallow_action(source_record, 'update?') }
context 'authorized for replace_comments? and unauthorized for update? on source record' do
before { stub_policy_actions(source_record, replace_comments?: true, update?: false) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end

context 'related records is empty' do
let(:related_records) { [] }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end
context 'unauthorized for replace_comments? and unauthorized for update? on source record' do
before { stub_policy_actions(source_record, replace_comments?: false, update?: false) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end

context 'authorized for replace_comments? on source record' do
before { stub_policy_actions(source_record, replace_comments?: true, update?: false) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
context 'where replace_<type>? is undefined' do
context 'authorized for update? on source record' do
before { stub_policy_actions(source_record, update?: true) }
it { is_expected.not_to raise_error }
end

context 'unauthorized for replace_comments? on source record' do
before { stub_policy_actions(source_record, replace_comments?: false, update?: false) }
context 'unauthorized for update? on source record' do
before { stub_policy_actions(source_record, update?: false) }
it { is_expected.to raise_error(::Pundit::NotAuthorizedError) }
end
end
Expand Down