Using krakenex with a proxy/ behind a proxy

[wwender]

Currently krakenex will not work with a proxy/behind a proxy without code change cause it's https requests are based on http.client and urllib.

Best would be to have it based on requests. There the system/OS proxy settings are automatically used.

What I did for krakenex was to change the connection.py. With a proxy at : myserver:1111 it has to be changed from
self.conn = http.client.HTTPSConnection(uri, timeout = timeout)

to

self.conn = http.client.HTTPSConnection("myserver:1111", timeout = timeout)
self.conn.set_tunnel(uri)

[veox]

Didn't dwell too much yet, but this does seem to be a more valid reason than #2.

[veox]

PR #36 implements this on current master.

[ScriptProdigy]

@veox if I may ask, why the choice for urllib and http.client over requests? To stay more to standard python libs? Or is there another technical reason you saw? Maybe just personal preference, I personally would have used requests out of preference, though not a problem. Saw this issue browsing and thought it interesting is all.

[veox]

"No dependencies" was the main reason, yes.

[ScriptProdigy]

Thanks for the quick reply, fair enough :) Thanks for creating this lib, works swell :D

[veox]

requests-updated has been merged to master. Also released v2.0.0a1 (alpha).