From 0ec2823a2370eb78a54fcfe9f4a1f07284f4d7b9 Mon Sep 17 00:00:00 2001
From: Marshall Bowers <elliott.codes@gmail.com>
Date: Fri, 7 Oct 2016 11:07:39 -0400
Subject: [PATCH] No string refs (#766)

* Use callback ref instead of string ref

* Enable react/no-string-refs rule for xo

* Replace additional string refs

* Fix broken merge
---
 lib/components/term.js | 17 ++++++++++++-----
 package.json           |  1 -
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/lib/components/term.js b/lib/components/term.js
index 31bc70475830..1f860e9244e1 100644
--- a/lib/components/term.js
+++ b/lib/components/term.js
@@ -67,7 +67,7 @@ export default class Term extends Component {
       // this.term.CursorNode_ is available at this point.
       this.term.setCursorShape(props.cursorShape);
     };
-    this.term.decorate(this.refs.term);
+    this.term.decorate(this.termRef);
     this.term.installKeyboard();
     if (this.props.onTerminal) {
       this.props.onTerminal(this.term);
@@ -191,8 +191,8 @@ export default class Term extends Component {
   handleMouseDown(ev) {
     // we prevent losing focus when clicking the boundary
     // wrappers of the main terminal element
-    if (ev.target === this.refs.term_wrapper ||
-        ev.target === this.refs.term) {
+    if (ev.target === this.termWrapperRef ||
+        ev.target === this.termRef) {
       ev.preventDefault();
     }
   }
@@ -271,13 +271,20 @@ export default class Term extends Component {
 
   template(css) {
     return (<div
-      ref="term_wrapper"
+      ref={component => {
+        this.termWrapperRef = component;
+      }}
       className={css('fit')}
       onMouseDown={this.handleMouseDown}
       style={{padding: this.props.padding}}
       >
       { this.props.customChildrenBefore }
-      <div ref="term" className={css('fit', 'term')}/>
+      <div
+        ref={component => {
+          this.termRef = component;
+        }}
+        className={css('fit', 'term')}
+        />
       { this.props.url ?
         <webview
           src={this.props.url}
diff --git a/package.json b/package.json
index f6e8777deaa8..8ed311b9411a 100644
--- a/package.json
+++ b/package.json
@@ -69,7 +69,6 @@
       "import/no-extraneous-dependencies": 0,
       "no-warning-comments": 0,
       "complexity": 0,
-      "react/no-string-refs": 0,
       "react/jsx-key": 0,
       "no-nested-ternary": 0,
       "react/jsx-no-bind": 0