Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Background Color Artifact on macOS Sierra #747

Closed
PatrickTulskie opened this issue Sep 25, 2016 · 10 comments
Closed

Weird Background Color Artifact on macOS Sierra #747

PatrickTulskie opened this issue Sep 25, 2016 · 10 comments
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@PatrickTulskie
Copy link

Since upgrading to macOS Sierra, some grey color backgrounds cause a weird block to appear in the window. In my config, I'm using #181818 but it seems to happen with a wide spectrum of grey colors. When I check the color of the box with Color Meter, it comes back as #242424. Also, the box seems to resize as you type text into the field.

Screenshot

Here's a copy of my config:

module.exports = {
  config: {
    fontSize: 12,
    fontFamily: 'Menlo, "DejaVu Sans Mono", "Lucida Console", monospace',
    cursorColor: 'rgba(248,28,229,0.75)',
    cursorShape: 'BLOCK',
    foregroundColor: '#F8F8F0',
    backgroundColor: '#181818',
    borderColor: '#272727',
    css: `
      .hyperterm_main {
        border: none !important;
      }
      .header_header {
        background: #272727 !important;
      }
      .tab_tab {
        border: 0;
      }
      .tab_active::before {
        border-bottom: 2px solid #FD971F;
      }
    `,
    termCSS: `
      ::selection {
        background-color: #ccc;
      },
      background-color: '#181818'
    `,
    padding: '12px 14px',

    colors: {
      black: '#272727',
      red: '#F92672',
      green: '#A6E22E',
      yellow: '#FD971F',
      blue: '#66D9EF',
      magenta: '#AE81FF',
      cyan: '#38CCD1',
      white: '#ffffff',
      lightBlack: '#808080',
      lightRed: '#F92672',
      lightGreen: '#A6E22E',
      lightYellow: '#FD971F',
      lightBlue: '#66D9EF',
      lightMagenta: '#AE81FF',
      lightCyan: '#38CCD1',
      lightWhite: '#ffffff'
    },
    shell: ''
  },

  plugins: ['hyperterm-blink'],
  localPlugins: []
};

HyperTerm 0.7.1
Electron 1.2.8
darwin x64 16.0.0

@PatrickTulskie
Copy link
Author

PatrickTulskie commented Sep 25, 2016

For giggles, I built the current master branch from source and tried it on Sierra. It doesn't do the weird box thing anymore. It does spread out the weird colored box across the screen though seemingly at random though. I can't seem to consistently reproduce it but it's still happening in a different way.

@timothyis timothyis added 🐛 Type: Bug Issue pertains to something wrong within Hyper help wanted Contributions wanted towards the issue labels Sep 25, 2016
@Greenek
Copy link

Greenek commented Sep 25, 2016

This is Chromium bug (https://bugs.chromium.org/p/chromium/issues/detail?id=633805) and it's related with non-standard color profiles. To fix it now you can: a) change color profile for that monitor, or b) run hyperterm with --enable-gpu-rasterization.

@PatrickTulskie
Copy link
Author

Thanks @Greenek I'll probably do the latter. How do I start hyperterm with that flag on macOS?

@Greenek
Copy link

Greenek commented Sep 29, 2016

Sorry, I forgot to reply! The easiest way I think is add

app.commandLine.appendSwitch('enable-gpu-rasterization', 'true');

somewhere around app/index.js#19 and rebuild.

@PatrickTulskie
Copy link
Author

Awesome thanks @Greenek.

Looks like Chromium Canary builds are now enabling that by default. Any downside to just doing that for Hyperterm by default?

@Greenek
Copy link

Greenek commented Sep 29, 2016

@PatrickTulskie I'm not sure. GPU rasterization is slower for text and I have seen many reports about problems on Linux (but it's not our problem, yet).

I made a simple test and after enabling GPU rasterization FPS drops from ~30 to ~20 while scrolling. At the screenshot below you can see that shape of the chart is much irregular for GPU raster enabled, but IMO it's hard to notice any difference without counter. Rendered fonts looks the same. But... it's just 5 minutes test in the single environment :)

zrzut ekranu 2016-09-29 o 16 38 49

![untitled-1](https://cloud.githubusercontent.com/assets/160300/18959584/0107870e-8667-11e6-8440-cc232e06cb0f.png)

@PatrickTulskie
Copy link
Author

Yeah dropping under 30fps is going to be noticeable. Probably not a good idea to add it as a default flag.

@timothyis timothyis added the 🍎 Platform: Mac Issue pertains to Mac label Oct 6, 2016
@webgefrickel
Copy link

I still have the same issue with Hyper 1.1.0.1408 on macOS 10.12.2 — any ideas on this besides the enable-gpu-rasterization-flag?

@eastcoastcoder
Copy link

I think this may be an Electron problem with graphics switching and the iGPU being disabled on MacBook Pros which have dGPUs.
Try my fix, also report back if anyone is having this issue that does NOT have a dGPU.

@Greenek
Copy link

Greenek commented Jan 14, 2018

It was Chromium bug, fixed long time ago in Electron 1.6.9/Chrome 56. Please close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests

6 participants