-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird Background Color Artifact on macOS Sierra #747
Comments
For giggles, I built the current master branch from source and tried it on Sierra. It doesn't do the weird box thing anymore. It does spread out the weird colored box across the screen though seemingly at random though. I can't seem to consistently reproduce it but it's still happening in a different way. |
This is Chromium bug (https://bugs.chromium.org/p/chromium/issues/detail?id=633805) and it's related with non-standard color profiles. To fix it now you can: a) change color profile for that monitor, or b) run hyperterm with |
Thanks @Greenek I'll probably do the latter. How do I start hyperterm with that flag on macOS? |
Sorry, I forgot to reply! The easiest way I think is add app.commandLine.appendSwitch('enable-gpu-rasterization', 'true'); somewhere around app/index.js#19 and rebuild. |
Awesome thanks @Greenek. Looks like Chromium Canary builds are now enabling that by default. Any downside to just doing that for Hyperterm by default? |
@PatrickTulskie I'm not sure. GPU rasterization is slower for text and I have seen many reports about problems on Linux (but it's not our problem, yet). I made a simple test and after enabling GPU rasterization FPS drops from ~30 to ~20 while scrolling. At the screenshot below you can see that shape of the chart is much irregular for GPU raster enabled, but IMO it's hard to notice any difference without counter. Rendered fonts looks the same. But... it's just 5 minutes test in the single environment :) ![untitled-1](https://cloud.githubusercontent.com/assets/160300/18959584/0107870e-8667-11e6-8440-cc232e06cb0f.png) |
Yeah dropping under 30fps is going to be noticeable. Probably not a good idea to add it as a default flag. |
I still have the same issue with Hyper 1.1.0.1408 on macOS 10.12.2 — any ideas on this besides the |
I think this may be an Electron problem with graphics switching and the iGPU being disabled on MacBook Pros which have dGPUs. |
It was Chromium bug, fixed long time ago in Electron 1.6.9/Chrome 56. Please close this ticket. |
Since upgrading to macOS Sierra, some grey color backgrounds cause a weird block to appear in the window. In my config, I'm using #181818 but it seems to happen with a wide spectrum of grey colors. When I check the color of the box with Color Meter, it comes back as #242424. Also, the box seems to resize as you type text into the field.
Here's a copy of my config:
HyperTerm 0.7.1
Electron 1.2.8
darwin x64 16.0.0
The text was updated successfully, but these errors were encountered: