From a049d69ac8b7c737967eaf2e43eaed6e22c17d01 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Mon, 12 Jun 2017 15:56:57 -0700 Subject: [PATCH 1/2] Addressing issue #1862 by filtering out Boolean values from the plugins list in the config. --- app/config/init.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/config/init.js b/app/config/init.js index d761d558403f..08adb58e267c 100644 --- a/app/config/init.js +++ b/app/config/init.js @@ -36,6 +36,8 @@ const _init = function (cfg) { notify('Error reading configuration: `config` key is missing'); return _extractDefault(cfg.defaultCfg); } + // Ignore undefined values in plugin array Issue #1862 + _cfg.plugins = _cfg.plugins.filter(Boolean); return _cfg; } return _extractDefault(cfg.defaultCfg); From 3b6243d40b9b7f91f9b60f496b7f45a8d137e0f9 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Mon, 12 Jun 2017 16:36:35 -0700 Subject: [PATCH 2/2] Updating the PR based on review comments. --- app/config/init.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/config/init.js b/app/config/init.js index 08adb58e267c..b62031bff74c 100644 --- a/app/config/init.js +++ b/app/config/init.js @@ -36,8 +36,9 @@ const _init = function (cfg) { notify('Error reading configuration: `config` key is missing'); return _extractDefault(cfg.defaultCfg); } - // Ignore undefined values in plugin array Issue #1862 - _cfg.plugins = _cfg.plugins.filter(Boolean); + // Ignore undefined values in plugin and localPlugins array Issue #1862 + _cfg.plugins = (_cfg.plugins && _cfg.plugins.filter(Boolean)) || []; + _cfg.localPlugins = (_cfg.localPlugins && _cfg.localPlugins.filter(Boolean)) || []; return _cfg; } return _extractDefault(cfg.defaultCfg);