Add ssh url scheme handling

[cyrilico]

Fixes #2039
PR is ready to be merged

Tested and working in macOS.
App also sets itself as the default ssh protocol client (only need to change defaultSSHClient boolean in app/config/config-default.js if user desires otherwise).
The URL components are retrieved using some simple regular expressions, it currently supports URLs of the type ssh://[username@]hostname[:port][[/]initial/remote/path]

Here is a short video showing the feature working: https://www.youtube.com/watch?v=gprDu_8n0KM

Note: Although it appears as if package.json was heavily modified, only a few small changes were made, however indentation issues made git recognise it as otherwise

[antonioalmeida]

Travis CI's check failed because it timed out after 20 minutes downloading a file at very slow speeds, the previous commit passed without problems

[diogotorres97]

Probably this error is related with Travis CI Status

[cyrilico]

@albinekb I believe all is ok now (once again)

[albinekb]

Very 💅 nice, @chabou can you have a look? I think this is ready to merge

[chabou]

I must test it against HyperCLI and test if we can add multiple URL schemes.
I will do it ASAP

[ppot]

you can just do config.getConfig().defaultSShApp no need to test if true or else if you need to implicitly test it you will need to config.getConfig().defaultSShApp === true

[antonioalmeida]

Yup, my bad, just fixed it

[diogotorres97]

@chabou @albinekb What is the current situation?

[albinekb]

LGTM

[diogotorres97]

@albinekb rebase done!

[chabou]

Thank you for your help 🙏. But there are some little things to change.

[chabou]

I'm think these regexp don't work.
For example, path is only matched if port is given:

'ssh://user@example.com:8080/tmp' -> 'ssh user@example.com -p 8080 -t "/tmp; bash"'
'ssh://user@example.com/tmp' -> 'ssh user@example.com'

We maybe should use something like: https://www.npmjs.com/package/parse-url

[antonioalmeida]

Yes, the regexp doesn't work on that case. I'll look into that package, but it's probably an overkill for this usage alone.

[chabou]

two things here:
I think that you forget to put cd before adding path.

But we shouldn't force remote shell to bash. I don't think that there is an elegant solution to change remote directory at start. Path should be ignored imo (like iTerm2 from my testing).

[antonioalmeida]

Yeah, this is an ugly workaround, better to ignore paths.

[antonioalmeida]

Update:

• ssh url parsing is now made using parse-url
• path is now ignored
  @chabou

[chabou]

@antonioalmeida I added 2 commits:

• First one to remove Hyper from default client for ssh:// protocol when user change its config.
• Second one to deal with parse-url dependency. We only use yarn (with pinned dependency) and its yarn.lock lockfiles. And we need to add package to app/package.json when it is used by main process.

It works great. Thank you so much 🙏 . I'll merge it ASAP.