increase timeout for update checks #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like, there are lots of them and GitHub is not happy. So increasing timeout 6x should fix that. In the end there is no need to check updates every 5 minutes. Fix vercel#880
|
isn't checking for update every 30 min a bit too often? once a day would probably be enough? (since releases are days/weeks apart) and then have a manual way to check if you really want the new version asap? Just a thought :) |
albinekb
approved these changes
Oct 24, 2016
albinekb
reviewed
Oct 24, 2016
| @@ -19,13 +19,9 @@ function init() { | |||
|
|
|||
| autoUpdater.setFeedURL(`${FEED_URL}/${version}`); | |||
|
|
|||
| setTimeout(() => { | |||
There was a problem hiding this comment.
now it won't check for update on startup? so if you start the app, use it for less than 30 minutes, it won't check at all 🤔
idk, it was 5m before. On the other hand, once a day, is not that good, 'because you'll get update next day |
|
lets start with 6x increase, we can find appropriate balance in the future |
|
sounds fair 👍 |
iamstarkov
force-pushed
the
fix/increase-timeout-for-updates
branch
from
64c86ca
to
ca93934
Compare
|
30 minutes is good. Think of Hyper more as a hot-reloadable website rather than a static app ;) |
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Nov 2, 2016
* master: chore(package): update electron to version 1.4.5 (vercel#949) add onRendererWindow, because it actually available. check ./lib/utils/plugins.js:193 (vercel#924) increase timeout for update checks (vercel#928) Change URL regex - fixes vercel#867 (vercel#943) Make the close menu items less ambiguous Comply to XO's no-warning-comments rule Prefer default export to make XO happy (vercel#931) chore(package): update ms to version 0.7.2 (vercel#933) chore(package): update copy-webpack-plugin to version 4.0.0 (vercel#927) log plugins' errors in Electron console (vercel#923) Improve tabs title (vercel#892) increase notification timeout up to 30m (vercel#913) Create github templates (vercel#919) chore(package): update electron to version 1.4.4 (vercel#907) Prevent Hterm to share same preferences between instances (vercel#906) 0.8.3 0.9.0 Revert "Quick full screen (vercel#803)" Ignore file watch errors. Fixes vercelGH-225 (vercel#893)
chabou
added a commit
to chabou/hyper
that referenced
this pull request
Nov 2, 2016
* master: chore(package): update electron to version 1.4.5 (vercel#949) add onRendererWindow, because it actually available. check ./lib/utils/plugins.js:193 (vercel#924) increase timeout for update checks (vercel#928) Change URL regex - fixes vercel#867 (vercel#943) Make the close menu items less ambiguous Comply to XO's no-warning-comments rule Prefer default export to make XO happy (vercel#931) chore(package): update ms to version 0.7.2 (vercel#933) chore(package): update copy-webpack-plugin to version 4.0.0 (vercel#927) log plugins' errors in Electron console (vercel#923) Improve tabs title (vercel#892) increase notification timeout up to 30m (vercel#913) Create github templates (vercel#919) chore(package): update electron to version 1.4.4 (vercel#907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is ready for code-review
It seems like, there are lots of them and GitHub is not happy.
So increasing timeout 6x should fix that. In the end there is no need
to check updates every 5 minutes.
Fix #880