Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure nested builds of __nccwpck_require__ #751

Merged
merged 2 commits into from Aug 19, 2021
Merged

fix: ensure nested builds of __nccwpck_require__ #751

merged 2 commits into from Aug 19, 2021

Conversation

@guybedford
Copy link
Collaborator

@guybedford guybedford commented Aug 19, 2021

This fixes the __nccwpck_require__ handling to ensure conflicts are avoided when running against a build that already has an __nccpck_require__ identifier. It uses numbering up to 9 given the limited space. We can look at increasing this limit in future though.

@guybedford guybedford requested review from styfle and Timer as code owners Aug 19, 2021
src/index.js Show resolved Hide resolved
Loading
src/index.js Outdated Show resolved Hide resolved
Loading
@styfle styfle requested a review from TooTallNate Aug 19, 2021
styfle
styfle approved these changes Aug 19, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

Loading

@styfle styfle merged commit cc96c83 into main Aug 19, 2021
5 checks passed
Loading
@styfle styfle deleted the nested-builds branch Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants