Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to webpack@5.61.0 #809

Merged
merged 1 commit into from Nov 8, 2021
Merged

feat: bump to webpack@5.61.0 #809

merged 1 commit into from Nov 8, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Nov 5, 2021

@jesec jesec requested review from styfle and Timer as code owners Nov 5, 2021
@styfle styfle requested a review from sokra Nov 8, 2021
styfle
styfle approved these changes Nov 8, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@@ -101,7 +101,6 @@ it('Should support custom watch API', async () => {
await new Promise((resolve, reject) => {
const watcher = new CustomWatchFileSystem(function watchStart (files, dirs, missing) {
expect(files._set.size).toBeGreaterThan(100);
expect(missing._set.size).toBeGreaterThan(40);
Copy link
Member

@styfle styfle Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was missing removed here?

Copy link
Contributor Author

@jesec jesec Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it unlikely to be useful.

As seen in earlier commit, 1bd2aac#diff-b886328ab4b91304e8f0ff17323f05d868c3f83cbb0a6c492f362fdedcd70f96, the line was changed to accommodate the new version of webpack.

Copy link
Member

@styfle styfle Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guybedford Thoughts on this? I'm fine with removing it.

@styfle styfle merged commit 75d90d4 into vercel:main Nov 8, 2021
5 checks passed
@styfle styfle mentioned this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants