Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add windows to CI #896

Merged
merged 10 commits into from Mar 31, 2022
Merged

chore: add windows to CI #896

merged 10 commits into from Mar 31, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 25, 2022

@styfle
Copy link
Member Author

styfle commented Mar 25, 2022

@yichi-yang Any thoughts what could be wrong here? Looks like the tests already strip \r but its still showing up

ncc/test/unit.test.js

Lines 22 to 23 in 905222e

// Windows support
.replace(/\r/g, "");

@yichi-yang
Copy link

yichi-yang commented Mar 25, 2022

@yichi-yang Any thoughts what could be wrong here? Looks like the tests already strip \r but its still showing up

I'm not super familiar with the unit test setup here, but just by looking at the code my guess would be it's actualSourceMap that contain \rs?

expect(actualSourceMap).toBe(expectedSourceMap);

@styfle
Copy link
Member Author

styfle commented Mar 25, 2022

That one also has a replace, so still not sure why it fails CI 🤔

ncc/test/unit.test.js

Lines 76 to 79 in 905222e

const actualSourceMap = map
.trim()
// Windows support
.replace(/\r/g, "");

@yichi-yang
Copy link

yichi-yang commented Mar 25, 2022

Ah I think you need /\\r/g instead of /\r/g. Those \rs in map appear to already have been escaped.

@styfle styfle marked this pull request as ready for review Mar 31, 2022
@styfle styfle requested a review from Timer as a code owner Mar 31, 2022
@styfle styfle enabled auto-merge (squash) Mar 31, 2022
@styfle styfle disabled auto-merge Mar 31, 2022
@styfle styfle merged commit 4c5fe12 into main Mar 31, 2022
7 checks passed
@styfle styfle deleted the add-windows-ci branch Mar 31, 2022
@styfle styfle mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants