Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump ts-loader from 8.3.0 to 9.3.0 #921

Merged
merged 1 commit into from May 25, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2022

Bumps ts-loader from 8.3.0 to 9.3.0.

Release notes

Sourced from ts-loader's releases.

v9.3.0

v9.2.9

v9.2.8

v9.2.7

v9.2.6

v9.2.5

v9.2.4

v9.2.3

v9.2.2

v9.2.1

v9.2.0

v9.1.2

v9.1.1

v9.1.0

v9.0.2

v9.0.1

v9.0.0

... (truncated)

Changelog

Sourced from ts-loader's changelog.

v9.3.0

v9.2.9

v9.2.8

v9.2.7

v9.2.6

v9.2.5

v9.2.4

v9.2.3

v9.2.2

v9.2.1

v9.2.0

v9.1.2

v9.1.1

... (truncated)

Commits
  • b943237 feat: add zero-config support for fork-ts-checker-webpack-plugin (#1451)
  • 4e00201 Bump tar in /examples/fork-ts-checker-webpack-plugin (#1370)
  • fc835fb Make v9 latest following v8 release (#1447)
  • 69576a6 Bump minimist from 1.2.5 to 1.2.6 in /examples/vanilla (#1443)
  • 12f4ffe Bug fix: support webpack 5 in ts-loader (#1439)
  • 65bb27c Bump lodash from 4.17.4 to 4.17.21 in /test/execution-tests/babel-es2015 (#1428)
  • e7a2ba6 Bump url-parse from 1.5.1 to 1.5.10 in /examples/vanilla (#1424)
  • 96ddcc5 Bump url-parse in /examples/fork-ts-checker-webpack-plugin (#1423)
  • ecdc9c1 Bump ajv in /examples/fork-ts-checker-webpack-plugin (#1412)
  • 5858b55 feat/4.6 (#1426)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from styfle and Timer as code owners May 1, 2022
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 1, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ts-loader-9.3.0 branch 2 times, most recently from 5141ba7 to ed3a0a9 Compare May 11, 2022
@shogo82148
Copy link
Contributor

shogo82148 commented May 25, 2022

Hi, can someone merge this pull request?

I have a problem with TypeScript v4.7.2 shogo82148/actions-create-release#495
and it looks that this problem is fixed in ts-loader v9.2.7.

> ncc build -o dist/create --source-map --license licenses.txt src/create.ts && ncc build -o dist/publish --source-map --license licenses.txt src/publish.ts

ncc: Version 0.33.4
ncc: Compiling file index.js into CJS
ncc: Using typescript@4.7.2 (local user-provided)
Error: Module build failed (from ./node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js):
Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
    at Object.resolveTypeReferenceDirective (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:42530:18)
    at /home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:316837
    at /home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:303785
    at Array.map (<anonymous>)
    at Object.resolveTypeReferenceDirectives (/home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:303777)
    at actualResolveTypeReferenceDirectiveNamesWorker (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:116611:163)
    at resolveTypeReferenceDirectiveNamesWorker (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:116911:26)
    at processTypeReferenceDirectives (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:118393:31)
    at findSourceFileWorker (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:118278:21)
    at findSourceFile (/home/runner/work/actions-create-release/actions-create-release/node_modules/typescript/lib/typescript.js:118133:26)
    at /home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1770552
    at /home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:374702
    at _done (eval at create (/home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:9:1)
    at eval (eval at create (/home/runner/work/actions-create-release/actions-create-release/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:34:22)

@sethvargo
Copy link

sethvargo commented May 25, 2022

@Timer any chance you could take a look at this (or get someone to take a look at it)? It's blocking a number of downstream compilations now that typescript 4.7 is being depended on more broadly.

lolPants added a commit to lolPants/discord-welcome-action that referenced this pull request May 25, 2022
pin typescript at 4.6 until vercel/ncc#921 is merged
@styfle
Copy link
Member

styfle commented May 25, 2022

@dependabot rebase

@styfle
Copy link
Member

styfle commented May 25, 2022

We'll eventually want to go with #926 so please give that PR a try and see if it works for you

Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 8.3.0 to 9.3.0.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases)
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md)
- [Commits](TypeStrong/ts-loader@v8.3.0...v9.3.0)

---
updated-dependencies:
- dependency-name: ts-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ts-loader-9.3.0 branch from ed3a0a9 to 46d281d Compare May 25, 2022
@styfle styfle added the automerge Automatically merge PR once checks pass label May 25, 2022
styfle
styfle approved these changes May 25, 2022
@kodiakhq kodiakhq bot merged commit 5901cc2 into main May 25, 2022
7 checks passed
@kodiakhq kodiakhq bot deleted the dependabot/npm_and_yarn/ts-loader-9.3.0 branch May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants