From 7bba4e9e258f3febb202d62f190e9ac5e7f1daaa Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Tue, 23 Apr 2024 18:26:56 -0700 Subject: [PATCH] Fix windows CI due to node release (#64950) There was a breaking change made in newer node versions on windows affecting our usage of spawn for running tests so this ensures the `shell: true` arg is set to avoid the `EINV` error doesn't occur. x-ref: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2 x-ref: [CI failure](https://dev.azure.com/nextjs/next.js/_build/results?buildId=85755&view=logs&jobId=22321aea-e36d-5ae1-4163-9a2b553ce318&j=8af7cf9c-43a1-584d-6f5c-57bad8880974&t=2b758e06-e4c9-54eb-5d48-87d8a97da130) Closes NEXT-3214 --- run-tests.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/run-tests.js b/run-tests.js index e88467a90c970..a2f656bdfa9db 100644 --- a/run-tests.js +++ b/run-tests.js @@ -529,6 +529,8 @@ ${ENDGROUP}`) ...process.env, ...env, }, + // See: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2 + shell: process.platform === 'win32', }) child.stdout.on('data', stdout) child.stderr.on('data', handleOutput('stderr'))