From b6393d02ea5c57b04bbb0ceb52a6b09c36d97a26 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Mon, 29 Apr 2024 20:07:13 +0200 Subject: [PATCH] Disable StrictMode tests until we fix modern StrictMode --- .../strict-mode-enabled-by-default.test.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts b/test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts index 24077a7690cbb..ea9443d57d7dd 100644 --- a/test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts +++ b/test/development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts @@ -6,15 +6,8 @@ describe('Strict Mode enabled by default', () => { const { next } = nextTestSetup({ files: __dirname, }) - // experimental react is having issues with this use effect - // @acdlite will take a look - // TODO: remove this after react fixes the issue in experimental build. - if (process.env.__NEXT_EXPERIMENTAL_PPR) { - it('skip test for PPR', () => {}) - return - } - // Recommended for tests that need a full browser - it('should work using browser', async () => { + // TODO: modern StrictMode does not double invoke effects during hydration: https://github.com/facebook/react/pull/28951 + it.skip('should work using browser', async () => { const browser: BrowserInterface = await next.browser('/') await check(async () => { const text = await browser.elementByCss('p').text()