From c7604475e616dfe8187db29ac46f16fef15267c2 Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Mon, 10 Apr 2023 19:01:23 +0200 Subject: [PATCH] update message to only show once --- packages/next/src/lib/metadata/resolvers/resolve-url.ts | 2 +- test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/next/src/lib/metadata/resolvers/resolve-url.ts b/packages/next/src/lib/metadata/resolvers/resolve-url.ts index b350ee6cf8cc..d523acee1194 100644 --- a/packages/next/src/lib/metadata/resolvers/resolve-url.ts +++ b/packages/next/src/lib/metadata/resolvers/resolve-url.ts @@ -29,7 +29,7 @@ function resolveUrl( // next build mode warning, add new line prefix for worker output console.log() Log.warnOnce( - `metadata.metadataBase is not set for resolving url "${url}", fallbacks to "${metadataBase.origin}". See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase` + `metadata.metadataBase is not set in root layout, fallbacks to "${metadataBase.origin}". See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase` ) } diff --git a/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts b/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts index 38651c0264c1..12fb6e8faf0a 100644 --- a/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts +++ b/test/e2e/app-dir/metadata-missing-metadata-base/index.test.ts @@ -10,9 +10,8 @@ createNextDescribe( it('should fallback to localhost if metadataBase is missing for absolute urls resolving', async () => { await next.fetch('/blog') expect(next.cliOutput).toInclude( - 'metadata.metadataBase is not set for resolving url "/blog/opengraph-image?' + 'metadata.metadataBase is not set in root layout, fallbacks to "http://localhost:' ) - expect(next.cliOutput).toInclude(', fallbacks to "http://localhost:') expect(next.cliOutput).toInclude( '. See https://beta.nextjs.org/docs/api-reference/metadata#metadatabase' )