Commits
canary
Name already in use
Commits on Dec 8, 2023
-
-
-
Update
swc_coretov0.86.98and turbopack (#59393)### What? Update SWC crates. ### Why? To fix OOM bug of `inputSourceMap`. Patch: swc-project/swc#8402 ### How? Closes PACK-2123 # Turbopack updates * vercel/turbo#6733 <!-- Thomas Knickman - chore(ignore): exclude rustic-ice files --> * vercel/turbo#6731 <!-- Leah - fix(turbopack-ecmascript-runtime): don't use `path.relative` for absolute paths --> * vercel/turbo#6745 <!-- Donny/강동윤 - Update `swc_core` to `v0.86.98` -->
-
-
Turbopack: switch to a single client components entrypoint (#59352)
### What? switch turbopack to use a single client components entrypoint for all client components on a page for development. This aligns it with the webpack behavior. ### Why? compiling a separate entrypoint for every client component is pretty expensive in regards of compilation, chunking, code generation, file writing and number of requests. ### Turbopack Changes * vercel/turbo#6713 <!-- Tobias Koppers - use real emojis --> * vercel/turbo#6728 <!-- Tobias Koppers - fix order of reverse topologic iteration --> Closes PACK-2115
Commits on Dec 7, 2023
-
-
Docs: Update Server Actions Docs (#59080)
- [x] Rename page from `forms-and-mutations` to `server-actions-and-mutations` to account for examples that don't use forms. - [x] Split `/pages` and `/app` content to make easier to edit - [x] Add Security Section - [x] Recommend tainting - [x] Closures and encryption - [x] Overwriting encryption keys - [x] CSRF protection | Allowed Origins - [x] Add examples for Server Actions being called outside forms - [x] `useEffect` - [x] Event handlers - [ ] ~3rd party libraries~ - [x] More form examples - [x] Add note on calling actions in `<button>` and `<input> ` - [x] Add `.bind` example | Recommend bind over hidden input field - [x] Recommend `try/catch` for error handling - [x] Create `serverActions` next.config.js page - [x] Document `allowedOrigins` - [x] Document `bodySizeLimit` - [x] Add note on Server Actions flag for < v14 - [x] Update error message links - [x] Remove Server Actions from API reference as it's a React feature. E.g. We don't have API references for Server Components. - [ ] Set up redirects: --------- Co-authored-by: Lee Robinson <me@leerob.io> Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: Michael Novotny <manovotny@gmail.com>
-
-
-
-
-
-
fixes the logging by showing full URLs only on demand (#58088)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes #58087 --> fixes #58087 Currently in Next 14, everyone has fullURL flag turned to true, this PR reverts the condition. --------- Co-authored-by: Jiachi Liu <inbox@huozhi.im>
-
test: ability to use node debugger (#56277)
Fixes ability to run `NODE_OPTIONS='--inspect' next dev` as described in [docs](https://nextjs.org/docs/pages/building-your-application/configuring/debugging), by removing inspect option from NODE_OPTIONS arg passed to worker process. This bug seem to have been introduced in 7d93808 as a part of a some refactoring. See how `getNodeOptionsWithoutInspect` is no longer used. Fixes #55862 --------- Co-authored-by: Jiachi Liu <inbox@huozhi.im>
-
fix inconsistent scroll restoration behavior (#59366)
### What? While scrolled on a page, and when following a link to a new page and clicking the browser back button or using `router.back()`, the scroll position would sometimes restore scroll to the incorrect spot (in the case of the test added in this PR, it'd scroll you back to the top of the list) ### Why? The refactor in #56497 changed the way router actions are processed: specifically, all actions were assumed to be async, even if they could be handled synchronously. For most actions this is fine, as most are currently async. However, `ACTION_RESTORE` (triggered when the `popstate` event occurs) isn't async, and introducing a small amount of delay in the handling of this action can cause the browser to not properly restore the scroll position ### How? This special-cases `ACTION_RESTORE` to synchronously process the action and call `setState` when it's received, rather than creating a promise. To consistently reproduce this behavior, I added an option to our browser interface that'll allow us to programmatically trigger a CPU slowdown. h/t to @alvarlagerlof for isolating the offending commit and sharing a minimal reproduction. Closes NEXT-1819 Likely addresses #58899 but the reproduction was too complex to verify.
-
Update Turbopack test manifest (#59356)
This auto-generated PR updates the integration test manifest used when testing Turbopack.
-
Update tests for Turbopack (#59354)
## What? - Add support for `experimental.externalDir` -- Was already supported, just makes Turbopack not fail on that config option - Skipped `with-babel` test because it tests Babel - Skipped `swc-warnings` test because it tests Babel - Skipped `config-resolve-alias` as it tests webpack config - Skipped `undefined-webpack-config` as it tests webpack config <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-1817
Commits on Dec 6, 2023
-
-
add
logLevelsupport to@next/bundle-analyzer(#59228)Co-authored-by: Jiachi Liu <inbox@huozhi.im>
-
fix edge route catch-all param parsing (#59343)
### What? Visiting an edge catch-all route incorrectly truncates multiple parameters ### Why? The params are currently coerced into a `ParsedURLQuery`-like format by calling `Object.fromEntries` on `searchParams`, but this doesn't consider multiple param values assigned to the same key ### How? Rather than use `fromEntries`, this uses an existing util to get the path into `ParsedURLQuery` format. Closes NEXT-1814 Fixes #59333
-
fix hmr in multi-zone handling (#59307)
### What? When running a [multi-zone](https://github.com/vercel/next.js/tree/canary/examples/with-zones) app in dev, app pages would infinitely reload ### Why? The HMR upgrade request would fail and get caught into a retry loop. In the multi-zone case, they fail because the upgrade request would be sent again for a request that had already been upgraded. This resulted in a "server.handleUpgrade() was called more than once with the same socket" error, causing the upgrade request to fail. Every time a retry occurred, the page would trigger a full refresh since certain HMR errors cause the browser to reload. ### How? This ensures the upgrade handler only responds to requests that match the configured basePath. Closes NEXT-1797 Fixes #59161 Fixes #56615 Fixes #54454
-
-
disable unused next/dynamic walking in app dir (#59338)
### What? remove expensive unused code Closes PACK-2108
-
* vercel/turbo#6716 <!-- Tobias Koppers - add support for export renaming in side effects optimization --> * vercel/turbo#6718 <!-- Tobias Koppers - cache the chunking work -->
-
Update Turbopack test manifest (#59326)
This auto-generated PR updates the integration test manifest used when testing Turbopack.
-
reduce function calls in walk (#59332)
### What? Reduce the number of function calls ### Why? Performance on incremental builds ### How? Closes PACK-2104
-
-
Move App Router client-side constants to separate file (#59239)
## What? Noticed constants.js was included in the client-side bundle. This ensures only the needed constants are included. ## How? Created a separate file for client-side constants. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-1789
-
-
side effects optimization (#58972)
### What? Code update for refactoring in vercel/turbo#6590 Closes PACK-2043
-
add module tracing for client reference and next/dynamic walking (#59306
) ### What? add tracing to the module graph walking Closes PACK-2090
-
remove additional static prefetch code (#59313)
This is a continuation from #58783 to remove the remaining code related to static prefetching.