Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Reload warning may not be seen #13070

Closed
Izhaki opened this issue May 19, 2020 · 2 comments
Closed

Full Reload warning may not be seen #13070

Izhaki opened this issue May 19, 2020 · 2 comments
Labels
good first issue Easy to fix issues, good for newcomers
Milestone

Comments

@Izhaki
Copy link

Izhaki commented May 19, 2020

Bug report

I'm filing it as a separate issue to #13024 although they are somewhat related.

Describe the bug

The warning about Full Reload can easily be missed because as soon as it is shown... the page reloads. Without specific browser settings, many users might miss it.

For me, I saw there was a warning, but couldn't read it until I enabled Preserve Log in Chrome.

To Reproduce

pages/index.js:

import '../src/somefile'

export default () => null;

Then edit and save somefile.

Expected behavior

The user should see the warning, regardless of browser settings.

It would be nice if the error shows after the reload, not before it

Screenshots

Full Reload

System information

  • Version of Next.js: 9.4.1
@Timer Timer modified the milestones: 9.4.2, 9.4.3 May 19, 2020
@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers help wanted labels May 25, 2020
@Timer Timer modified the milestones: 9.4.3, 9.4.4 May 28, 2020
@Timer Timer removed the help wanted label Jun 3, 2020
@Timer Timer modified the milestones: 9.4.5, 9.x.x Jun 29, 2020
@Timer
Copy link
Member

Timer commented Aug 6, 2020

Duplicate of #14701

@Timer Timer marked this as a duplicate of #14701 Aug 6, 2020
@Timer Timer closed this as completed Aug 6, 2020
@Timer Timer modified the milestones: 9.x.x, iteration 6 Aug 6, 2020
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants