next/inline-script-id does not handle JSXSpreadAttributes correctly

[no-yan]

Run next info (available from version 12.0.8 and up)

No response

What version of Next.js are you using?

canary

What version of Node.js are you using?

16.13.0

What browser are you using?

no

What operating system are you using?

Ubuntu 20.04.3 LTS

How are you deploying your application?

no

Describe the Bug

In response to comment: #32421 (comment)

An error occurs because the rule next/inline-script-id does not handle JSXSpreadAttribute correctly.
After #32178, It may still give an error when there is a JSXSpreadAttribute.
JSXSpreadAttribute can be any AssignmentExpression (Spec) , but inline-script-id only supports special cases.
That is based on the assumption, every JSXSpreadAttribute have property key.name.

Source:

next.js/packages/eslint-plugin-next/lib/rules/inline-script-id.js

Lines 34 to 36 in 6b73acf

	} else if (attribute.type === 'JSXSpreadAttribute') {
	attribute.argument.properties.forEach((property) => {
	attributeNames.add(property.key.name)

When a SpreadAttribute is passed, it will be a variable in most cases. If so, Eslint cannot find the property name.
To support other cases, we can build some complex logic, but I don't think it is worth it.
Can't we simply ignore the JSXSpreadAttribute?

Expected Behavior

Rules should not report error when JSXSpreadAttribute is exist.

To Reproduce

The failing case I checked is the following code.

{
  code: `import Script from 'next/script';
  const spread = { strategy: "lazyOnload" }
  export default function TestPage() {
    return (
      <Script {...spread} id={"test-script"}>
        {\`console.log('Hello world');\`}
      </Script>
    )
  }`,
},

You can confirm AST of this by using https://astexplorer.net/ .
@stefanprobst

[no-yan]

I would like to implement this, but I would like to hear your opinion first.

[ijjk]

Hi, thanks for looking into this, yeah if the spread attribute is not able to be checked for the values we should definitely ignore it in that case instead of showing an error, a PR updating this would be welcome!

[rohan-kulkarni-25]

Hey @ijjk !! I will like to work on this issue can you please guide me on this !!

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.