Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with-redux-toolkit example #11358

Merged
merged 3 commits into from Mar 26, 2020
Merged

Add with-redux-toolkit example #11358

merged 3 commits into from Mar 26, 2020

Conversation

@JazibJafri
Copy link
Contributor

@JazibJafri JazibJafri commented Mar 26, 2020

Related to #11097
Discussion here

@ijjk
Copy link
Member

@ijjk ijjk commented Mar 26, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
buildDuration 11s 11.3s ⚠️ +306ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
index.html gzip 918 B 918 B
link.html gzip 926 B 926 B
withRouter.html gzip 914 B 914 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
buildDuration 12.1s 11.9s -206ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_error.js gzip 293 kB 294 kB ⚠️ +876 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 957 B 957 B
index.js gzip 293 kB 294 kB ⚠️ +491 B
link.js gzip 301 kB 301 kB ⚠️ +134 B
routerDirect.js gzip 300 kB 300 kB -119 B
withRouter.js gzip 300 kB 300 kB ⚠️ +114 B
Overall change 1.49 MB 1.49 MB ⚠️ +1.5 kB

@ijjk
Copy link
Member

@ijjk ijjk commented Mar 26, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
buildDuration 11.3s 11.4s ⚠️ +43ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
index.html gzip 918 B 918 B
link.html gzip 926 B 926 B
withRouter.html gzip 914 B 914 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
buildDuration 12.2s 12.3s ⚠️ +88ms
nodeModulesSize 53 MB 53 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.js gzip 6.24 kB 6.24 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.2 kB 56.2 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary JazibJafri/next.js with-redux-toolkit Change
_error.js gzip 293 kB 294 kB ⚠️ +1.17 kB
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 957 B 957 B
index.js gzip 294 kB 294 kB -168 B
link.js gzip 301 kB 301 kB ⚠️ +74 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +39 B
withRouter.js gzip 299 kB 300 kB ⚠️ +703 B
Overall change 1.49 MB 1.49 MB ⚠️ +1.82 kB

@JazibJafri
Copy link
Contributor Author

@JazibJafri JazibJafri commented Mar 26, 2020

@lfades, @Timer hey, merging with your canary failed the lint test, What should I do?

lfades
lfades approved these changes Mar 26, 2020
Copy link
Member

@lfades lfades left a comment

@JazibJafri Thank you 🥇

@lfades lfades merged commit e02b66a into vercel:canary Mar 26, 2020
20 checks passed
@JazibJafri
Copy link
Contributor Author

@JazibJafri JazibJafri commented Mar 27, 2020

@JazibJafri Thank you 🥇

No problem :) I guess you can also close the related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants