Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow React experimental version without warning #16140

Merged
merged 3 commits into from Aug 18, 2020
Merged

Allow React experimental version without warning #16140

merged 3 commits into from Aug 18, 2020

Conversation

jamesmosier
Copy link
Contributor

React uses 0.0.0-experimental-<sha> (or 0.0.0-<sha>) for their experimental builds. When using these experimental versions of React, Next would output a warning notifying the user that Fast Refresh will not work. This fix ensures the react and react-dom versions are not equal to 0.0.0 before showing the warning.

Fixes #16103

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
buildDuration 11.8s 11.3s -506ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +604 B
Page Load Tests Overall increase ✓
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.186 2.093 -0.09
/ avg req/sec 1143.39 1194.66 +51.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.359 1.329 -0.03
/error-in-render avg req/sec 1839.54 1881.35 +41.81
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-25aa383..eece.js gzip 6.72 kB 6.72 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-08f768c..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
index.html gzip 947 B 947 B ✓
link.html gzip 955 B 955 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
buildDuration 13s 13.1s ⚠️ +144ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +604 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..ee8a.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-25aa383..eece.js gzip 6.72 kB 6.72 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-08f768c..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 54a327b

@Timer Timer self-assigned this Aug 13, 2020
@ijjk
Copy link
Member

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
buildDuration 12.2s 12s -133ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +604 B
Page Load Tests Overall increase ✓
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.164 2.19 ⚠️ +0.03
/ avg req/sec 1155.3 1141.7 ⚠️ -13.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.206 1.191 -0.01
/error-in-render avg req/sec 2073.45 2098.77 +25.32
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6444cad..dba4.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-532811e..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
index.html gzip 946 B 946 B ✓
link.html gzip 951 B 951 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
buildDuration 13.9s 13.6s -329ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +604 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6444cad..dba4.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-532811e..dule.js gzip 6.18 kB 6.18 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary jamesmosier/next.js fix/react-experimental-version-check Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: b7aa736

@Timer Timer changed the title Check for React experimental version before showing fast refresh warning Allow React experimental version without warning Aug 18, 2020
@Timer Timer merged commit 29ae372 into vercel:canary Aug 18, 2020
@jamesmosier jamesmosier deleted the fix/react-experimental-version-check branch August 18, 2020 13:49
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@jamesmosier @Timer
Allow React experimental version without warning (vercel#16140)
a4ba14a 
Co-authored-by: Joe Haddad <joe.haddad@zeit.co>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees

@Timer Timer

Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fast refresh disabled warning with react experimental version
3 participants
@jamesmosier @ijjk @Timer