Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): respect extends in tsconfig with exclude and include #16619

Merged
merged 8 commits into from Jan 24, 2021
Merged

fix(next): respect extends in tsconfig with exclude and include #16619

merged 8 commits into from Jan 24, 2021

Conversation

calmonr
Copy link
Contributor

@calmonr calmonr commented Aug 27, 2020

I was setting up a monorepo with a base tsconfig.json and Next.js was respecting most of its configuration when extending but it was ignoring the exclude and include options.

The problem is that CommentJson.parse will parse the tsconfig.json but it won't resolve the extending one.

const userTsConfigContent = await fs.readFile(tsConfigPath, {
encoding: 'utf8',
})
const userTsConfig = CommentJson.parse(userTsConfigContent)

If you have a tsconfig.json like this:

{
  "extends": "./tsconfig.base.json"
}

This is always going to be true (null) even if the tsconfig.base.json has compilerOptions.

if (userTsConfig.compilerOptions == null) {
userTsConfig.compilerOptions = {}
isFirstTimeSetup = true
}

The result would be something like this in your tsconfig.json when running the application:

{
  "extends": "./tsconfig.base.json",
  "compilerOptions": {}
}

The compilerOptions is only empty because the next step is to evaluate if the tsconfig.json has the required options by using ts.parseJsonConfigFileContent:

const result = ts.parseJsonConfigFileContent(
config,
ts.sys,
path.dirname(tsConfigPath)
)

The ts.parseJsonConfigFileContent will resolve the tsconfig.base.json with all the compilerOptions. If you have all the required options there you are good to go but with an empty "compilerOptions": {} in your tsconfig.json (due to the null checking).

The best way to solve these 2 problems is by using the return from ts.parseJsonConfigFileContent.

  1. The first problem we have is to remove the empty compilerOptions when we are extending another tsconfig with all the required options.

Solution: isFirstTimeSetup should only be true if we have a totally empty tsconfig.

  1. The second problem we have is respecting the exclude and include options.

Solution: CommentJson.parse will always return empty for exclude and include when extending. We should actually check against the raw config returned by ts.parseJsonConfigFileContent.


Note: it's totally possible to get rid of CommentJson (it's kinda useless here).

const { config, error } = ts.readConfigFile(tsConfigPath, ts.sys.readFile)

ts.readConfigFile returns the config, it's only needed to assign that to another variable, modify and save using fs.writeFile and JSON.stringify.

It would require modifying the getTypeScriptConfiguration function to return not only the result of ts.parseJsonConfigFileContent but also the config from ts.readConfigFile.

I didn't change this portion cause this is not the main issue here but just to keep in mind.

Thank you.

@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 12.6s 13.3s ⚠️ +743ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.287 2.323 ⚠️ +0.04
/ avg req/sec 1092.99 1076.14 ⚠️ -16.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.26 1.233 -0.03
/error-in-render avg req/sec 1984.63 2028.24 +43.61
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.4 kB 57.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-9973c26..dule.js gzip 6.42 kB 6.42 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 972 B 972 B
link.html gzip 978 B 978 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 14.1s 14.1s ⚠️ +27ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.4 kB 57.4 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-9973c26..dule.js gzip 6.42 kB 6.42 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: 2b46dba

@ijjk
Copy link
Member

ijjk commented Aug 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 13.4s 13.1s -343ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.545 2.53 -0.02
/ avg req/sec 982.42 988.07 +5.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.589 1.502 -0.09
/error-in-render avg req/sec 1573.52 1664.67 +91.15
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-9973c26..dule.js gzip 6.42 kB 6.42 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 972 B 972 B
link.html gzip 978 B 978 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 14.7s 14.9s ⚠️ +244ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-9973c26..dule.js gzip 6.42 kB 6.42 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: 73f2258

Copy link
Member

@Timer Timer left a comment

This is missing tests, please add them!

@calmonr calmonr requested a review from Timer Aug 30, 2020
@ijjk
Copy link
Member

ijjk commented Aug 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 11.8s 11.8s ⚠️ +12ms
nodeModulesSize 57.4 MB 57.4 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.306 2.317 ⚠️ +0.01
/ avg req/sec 1084.28 1079.14 ⚠️ -5.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.512 1.372 -0.14
/error-in-render avg req/sec 1653.05 1821.89 +168.84
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 971 B 971 B
link.html gzip 977 B 977 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 13.4s 13.2s -191ms
nodeModulesSize 57.4 MB 57.4 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: b785bc0

@calmonr
Copy link
Contributor Author

calmonr commented Sep 1, 2020

This is missing tests, please add them!

@Timer There you go. 👍

@ijjk
Copy link
Member

ijjk commented Oct 12, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 12.9s 12.6s -350ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.44 2.544 ⚠️ +0.1
/ avg req/sec 1024.39 982.57 ⚠️ -41.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.57 1.526 -0.04
/error-in-render avg req/sec 1591.98 1637.75 +45.77
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-2540b2f..aa10.js gzip 7.22 kB 7.22 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58 kB 58 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0d1e0b8..dule.js gzip 6.28 kB 6.28 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.73 kB 7.73 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-92d3016..dule.js gzip 1.28 kB 1.28 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 14.2s 14.2s -74ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..133b.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-2540b2f..aa10.js gzip 7.22 kB 7.22 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58 kB 58 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-0d1e0b8..dule.js gzip 6.28 kB 6.28 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.73 kB 7.73 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-92d3016..dule.js gzip 1.28 kB 1.28 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.05 MB 1.05 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.05 MB 1.05 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.09 MB 1.09 MB
withRouter.js 1.09 MB 1.09 MB
Overall change 5.41 MB 5.41 MB
Commit: 313216b

@calmonr
Copy link
Contributor Author

calmonr commented Oct 19, 2020

@Timer @timneutkens Is everything good here? Thank you.

@ijjk
Copy link
Member

ijjk commented Oct 19, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 12.4s 12.3s -118ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.292 2.293 0
/ avg req/sec 1090.8 1090.5 ⚠️ -0.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.271 1.21 -0.06
/error-in-render avg req/sec 1966.32 2066.63 +100.31
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5aa1543..4e79.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-7d849dd..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 14.1s 14s -54ms
nodeModulesSize 64.4 MB 64.4 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5aa1543..4e79.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-7d849dd..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 473ba21

@ijjk
Copy link
Member

ijjk commented Oct 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 12.5s 11.9s -612ms
nodeModulesSize 91.2 MB 91.2 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.513 2.538 ⚠️ +0.02
/ avg req/sec 994.9 985.15 ⚠️ -9.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.417 1.383 -0.03
/error-in-render avg req/sec 1763.97 1808.31 +44.34
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-23d7afb..be6f.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-ccae7c3..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 994 B 994 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 13.3s 14.1s ⚠️ +835ms
nodeModulesSize 91.2 MB 91.2 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..35e7.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-23d7afb..be6f.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-ccae7c3..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.06 MB 1.06 MB
404.html 4.73 kB 4.73 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 2f2ef7a

@ijjk
Copy link
Member

ijjk commented Oct 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 11.6s 11.8s ⚠️ +238ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +19 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 2.229 2.307 ⚠️ +0.08
/ avg req/sec 1121.43 1083.58 ⚠️ -37.85
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.195 1.179 -0.02
/error-in-render avg req/sec 2092.09 2120.42 +28.33
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-20f9619..dule.js gzip 6.31 kB 6.31 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.4 kB 5.4 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 13.3s 13.5s ⚠️ +203ms
nodeModulesSize 91.3 MB 91.3 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..3aa9.js gzip 11.3 kB 11.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-fc2ed98..cd2b.js gzip 7.33 kB 7.33 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.3 kB 58.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..dule.js gzip 7.03 kB 7.03 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-20f9619..dule.js gzip 6.31 kB 6.31 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.1 kB 53.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-41ceea0..6b62.js gzip 1.35 kB 1.35 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.75 kB 7.75 kB
Client Pages Modern
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-2d41a89..dule.js gzip 1.31 kB 1.31 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.4 kB 5.4 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1.06 MB 1.06 MB
404.html 4.73 kB 4.73 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.11 MB 1.11 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.43 MB 5.43 MB
Commit: 41b4d68

@calmonr
Copy link
Contributor Author

calmonr commented Jan 23, 2021

It's been months and no response, should I close this?

@Timer @lfades @timneutkens @ijjk

Copy link
Member

@timneutkens timneutkens left a comment

This looks good now, thanks!

@calmonr
Copy link
Contributor Author

calmonr commented Jan 23, 2021

Thank you @timneutkens

@ijjk
Copy link
Member

ijjk commented Jan 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 8.7s 8.7s
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +19 B
Page Load Tests Overall increase ✓
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 1.737 1.768 ⚠️ +0.03
/ avg req/sec 1439.29 1413.82 ⚠️ -25.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.101 1.082 -0.02
/error-in-render avg req/sec 2270.35 2310.58 +40.23
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 10.3s 10.2s -171ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +19 B
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
buildDuration 10.5s 10.8s ⚠️ +316ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +19 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
/ failed reqs 0 0
/ total time (seconds) 1.686 1.708 ⚠️ +0.02
/ avg req/sec 1483.08 1464.04 ⚠️ -19.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.091 1.088 0
/error-in-render avg req/sec 2290.99 2297.15 +6.16
Client Bundles (main, webpack, commons)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary calmonr/next.js fix-tsconfig-extends Change
index.html gzip 588 B 588 B
link.html gzip 593 B 593 B
withRouter.html gzip 581 B 581 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "SNjKwVlS02QMp6H9QVXhQ",
+        "buildId": "iDczP6ElzlUj9zQNdXlND",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_buildManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_ssgManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "SNjKwVlS02QMp6H9QVXhQ",
+        "buildId": "iDczP6ElzlUj9zQNdXlND",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_buildManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_ssgManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "SNjKwVlS02QMp6H9QVXhQ",
+        "buildId": "iDczP6ElzlUj9zQNdXlND",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_buildManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/SNjKwVlS02QMp6H9QVXhQ/_ssgManifest.js"
+      src="/_next/static/iDczP6ElzlUj9zQNdXlND/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 87ae7a4

@timneutkens timneutkens merged commit 783b9d8 into vercel:canary Jan 24, 2021
29 of 31 checks passed
@calmonr calmonr deleted the fix-tsconfig-extends branch Jan 24, 2021
@markhughes
Copy link

markhughes commented Sep 15, 2021

FYI this does not work if that tsconfig extends another tsconfig - might not work 100% with the tsconfig.build -> tsconfig -> ../../tsconfig flow for monorepos

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants