Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the image post-processor ignore SVG images #16732

Merged
merged 6 commits into from Sep 2, 2020

Conversation

atcastle
Copy link
Collaborator

This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.

@ijjk
Copy link
Member

ijjk commented Aug 31, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 12.9s 13.3s ⚠️ +441ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +656 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
/ failed reqs 0 0
/ total time (seconds) 2.324 2.314 -0.01
/ avg req/sec 1075.76 1080.19 +4.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.24 1.283 ⚠️ +0.04
/error-in-render avg req/sec 2016.33 1948.71 ⚠️ -67.62
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
index.html gzip 971 B 971 B
link.html gzip 977 B 977 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 14.3s 14.3s ⚠️ +76ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +656 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_error.js 1.03 MB 1.03 MB ⚠️ +221 B
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB ⚠️ +221 B
link.js 1.07 MB 1.07 MB ⚠️ +221 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +221 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +221 B
Overall change 5.28 MB 5.28 MB ⚠️ +1.1 kB
Commit: 85b087e

timneutkens
timneutkens previously approved these changes Sep 1, 2020
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Timer
Timer approved these changes Sep 2, 2020
@ijjk
Copy link
Member

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 12.8s 12.8s ⚠️ +70ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +672 B
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
/ failed reqs 0 0
/ total time (seconds) 2.428 2.4 -0.03
/ avg req/sec 1029.66 1041.56 +11.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.397 1.39 -0.01
/error-in-render avg req/sec 1788.93 1798.08 +9.15
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-830c506..dule.js gzip 6.37 kB 6.37 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
index.html gzip 971 B 971 B
link.html gzip 976 B 976 B
withRouter.html gzip 965 B 965 B
Overall change 2.91 kB 2.91 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 14.7s 14.8s ⚠️ +36ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +672 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-830c506..dule.js gzip 6.37 kB 6.37 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_error.js 1.03 MB 1.03 MB ⚠️ +223 B
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB ⚠️ +223 B
link.js 1.07 MB 1.07 MB ⚠️ +223 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +223 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +223 B
Overall change 5.28 MB 5.28 MB ⚠️ +1.11 kB
Commit: d2ce0ec

@ijjk
Copy link
Member

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 13.3s 13.4s ⚠️ +106ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +672 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
/ failed reqs 0 0
/ total time (seconds) 2.437 2.508 ⚠️ +0.07
/ avg req/sec 1026.05 996.71 ⚠️ -29.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.515 1.558 ⚠️ +0.04
/error-in-render avg req/sec 1649.96 1604.15 ⚠️ -45.81
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-830c506..dule.js gzip 6.37 kB 6.37 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
index.html gzip 971 B 971 B
link.html gzip 976 B 976 B
withRouter.html gzip 965 B 965 B
Overall change 2.91 kB 2.91 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
buildDuration 14.9s 15.2s ⚠️ +223ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +672 B
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-830c506..dule.js gzip 6.37 kB 6.37 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary azukaru/next.js fix-image-preload-tag Change
_error.js 1.03 MB 1.03 MB ⚠️ +223 B
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB ⚠️ +223 B
link.js 1.07 MB 1.07 MB ⚠️ +223 B
routerDirect.js 1.07 MB 1.07 MB ⚠️ +223 B
withRouter.js 1.07 MB 1.07 MB ⚠️ +223 B
Overall change 5.28 MB 5.28 MB ⚠️ +1.11 kB
Commit: f8b4462

@kodiakhq kodiakhq bot merged commit 6874adb into vercel:canary Sep 2, 2020
ijjk pushed a commit to ijjk/next.js that referenced this pull request Sep 2, 2020
This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants