Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic reloading when editing GS(S)P methods #16744

Merged
merged 20 commits into from Sep 2, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 1, 2020

This adds initial support for reloading the page when getStaticProps, getStaticPaths, or getServerSideProps were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output.

Closes: #13949

@ijjk
Copy link
Member Author

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 10s 10.1s ⚠️ +89ms
nodeModulesSize 56.8 MB 56.8 MB ⚠️ +5.81 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
/ failed reqs 0 0
/ total time (seconds) 1.828 1.879 ⚠️ +0.05
/ avg req/sec 1367.32 1330.38 ⚠️ -36.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.049 1.049
/error-in-render avg req/sec 2382.58 2382.35 ⚠️ -0.23
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
index.html gzip 971 B 971 B
link.html gzip 977 B 977 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 11.4s 11.6s ⚠️ +204ms
nodeModulesSize 56.8 MB 56.8 MB ⚠️ +5.81 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-49b1fd5..c64c.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-99715b4..dule.js gzip 6.4 kB 6.4 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.2 kB 52.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-000f151..65d4.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: f44fa5e

@ijjk
Copy link
Member Author

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 11.6s 12.1s ⚠️ +478ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +5.81 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
/ failed reqs 0 0
/ total time (seconds) 2.116 2.082 -0.03
/ avg req/sec 1181.58 1201.01 +19.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.165 1.161 0
/error-in-render avg req/sec 2145.95 2154.22 +8.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-2db3d72..5955.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-d7fe688..dule.js gzip 6.41 kB 6.41 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
index.html gzip 971 B 971 B
link.html gzip 976 B 976 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 13.5s 13.5s -24ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +5.81 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-2db3d72..5955.js gzip 7.35 kB 7.35 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-d7fe688..dule.js gzip 6.41 kB 6.41 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-ae98065..267e.js gzip 1.29 kB 1.29 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.69 kB 7.69 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.35 kB 5.35 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.07 MB 1.07 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.28 MB 5.28 MB
Commit: 85aab1a

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call router.replace on the current route to refresh the props without throwing away page state!

arthurjdam and others added 13 commits September 2, 2020 11:25
* feat Export return type for GetStaticPaths

* add Duplicate generic

Co-authored-by: Luis Alvarez D <luis@vercel.com>
* refactor: remove useless console.log

* fix: replace broken images

* Updated title

Co-authored-by: Luis Alvarez <luis@vercel.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Closes vercel#16538 

Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
…el#16085)

This PR is to fix "[Examples] Problem with query parameters in with-redux-persist (vercel#15484)"
The root cause is 
persist/rehydrate action will issue twice when query parameter is set. But persistStore initial bootstrap is not ready yet. So i add a bootstrap callback and force persistor to persist again to make overall state correct. I also modify the loading prop to a `<div>loading</div>` because it's confuse to set Component in loading prop. 

Attached the GIF
![demo](https://user-images.githubusercontent.com/1462027/89922530-bec04000-dc31-11ea-9831-12cd9d436d96.gif)

Closes vercel#15484
This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.
Since the error overlay could be dismissed before this is resolved we need to make sure the component is still mounted before updating the state.
…6360)

* Create _document.js

 Includes the lang attribute with current language inside the <html> tag.

* Lint fix

Co-authored-by: Luis Alvarez D <luis@vercel.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@ijjk ijjk requested a review from chibicode as a code owner September 2, 2020 16:27
@ijjk ijjk added area: create-next-app CLI (create-next-app) area: documentation area: examples Anything inside the examples folder labels Sep 2, 2020
@ijjk ijjk requested a review from Timer September 2, 2020 16:28
@ijjk
Copy link
Member Author

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 11.2s 11.7s ⚠️ +554ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +6.81 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
/ failed reqs 0 0
/ total time (seconds) 2.093 2.098 0
/ avg req/sec 1194.72 1191.86 ⚠️ -2.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.271 1.256 -0.01
/error-in-render avg req/sec 1967.62 1991.23 +23.61
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f8f2cfe..033f.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a6f8e84..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
index.html gzip 972 B 972 B
link.html gzip 977 B 977 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 12.9s 12.8s -134ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +6.81 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f8f2cfe..033f.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a6f8e84..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.29 MB 5.29 MB
Commit: 9df55a0

@ijjk
Copy link
Member Author

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 14.1s 14.1s -50ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +6.81 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
/ failed reqs 0 0
/ total time (seconds) 2.635 2.572 -0.06
/ avg req/sec 948.62 972.18 +23.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.568 1.537 -0.03
/error-in-render avg req/sec 1594.49 1626.42 +31.93
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f8f2cfe..033f.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a6f8e84..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
index.html gzip 972 B 972 B
link.html gzip 977 B 977 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
buildDuration 15.6s 15.8s ⚠️ +181ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +6.81 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f8f2cfe..033f.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-a6f8e84..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary ijjk/next.js add/gsp-reloading Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.29 MB 5.29 MB
Commit: 498be1b

@ijjk ijjk removed the area: create-next-app CLI (create-next-app) label Sep 2, 2020
Timer
Timer approved these changes Sep 2, 2020
@kodiakhq kodiakhq bot merged commit 4685332 into vercel:canary Sep 2, 2020
@ijjk ijjk deleted the add/gsp-reloading branch September 2, 2020 16:57
kodiakhq bot pushed a commit that referenced this pull request Sep 3, 2020
…16789)

This is a follow-up to #16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring 

Closes: #16790
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
This adds initial support for reloading the page when `getStaticProps`, `getStaticPaths`, or `getServerSideProps` were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output. 

Closes: vercel#13949
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
…ercel#16789)

This is a follow-up to vercel#16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring 

Closes: vercel#16790
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: documentation area: examples Anything inside the examples folder type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically reload page when editing getStaticProps
7 participants