Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(next): use require.resolve instead of resolve #19518

Merged
merged 2 commits into from Jan 11, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Nov 25, 2020

What's the problem this PR addresses?

How did you fix it?

@vercel vercel bot temporarily deployed to Preview Nov 25, 2020 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 25, 2020

Failing test suites

Commit: 22d414e

test/integration/amphtml-custom-validator/test/index.test.js

  • AMP Custom Validator > should build and start successfully
  • AMP Custom Validator > should run in dev mode successfully
Expand output

● AMP Custom Validator › should build and start successfully

FetchError: request to http://localhost:37589/ failed, reason: connect ECONNREFUSED 127.0.0.1:37589

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● AMP Custom Validator › should run in dev mode successfully

FetchError: request to http://localhost:43143/ failed, reason: connect ECONNREFUSED 127.0.0.1:43143

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

test/integration/amphtml-custom-optimizer/test/index.test.js

  • AMP Custom Optimizer > should build and start for static page
  • AMP Custom Optimizer > should build and start for dynamic page
Expand output

● AMP Custom Optimizer › should build and start for static page

FetchError: request to http://localhost:35987/ failed, reason: connect ECONNREFUSED 127.0.0.1:35987

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● AMP Custom Optimizer › should build and start for dynamic page

FetchError: request to http://localhost:34601/dynamic failed, reason: connect ECONNREFUSED 127.0.0.1:34601

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

test/integration/chunking/test/index.test.js

  • Chunking > should use all url friendly names
  • Chunking > should create a framework chunk
  • Chunking > should not create a commons chunk
  • Chunking > should not create a lib chunk for react or react-dom
  • Chunking > should not preload the build manifest
  • Chunking > should execute the build manifest
  • Chunking > should not include more than one instance of react-dom
  • Chunking > Serving > should hydrate with aggressive chunking
  • Chunking > Serving > should load chunks when navigating
Expand output

● Chunking › should use all url friendly names

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should create a framework chunk

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should not create a commons chunk

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should not create a lib chunk for react or react-dom

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should not preload the build manifest

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should execute the build manifest

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › should not include more than one instance of react-dom

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › Serving › should hydrate with aggressive chunking

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Chunking › Serving › should load chunks when navigating

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/chunking/.next/stats.json'

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/chunking/test/index.test.js:52:18

test/integration/404-page-ssg/test/index.test.js

  • 404 Page Support SSG > dev mode > should respond to 404 correctly
  • 404 Page Support SSG > dev mode > should render error correctly
  • 404 Page Support SSG > dev mode > should not show an error in the logs for 404 SSG
  • 404 Page Support SSG > dev mode > should render index page normal
  • 404 Page Support SSG > server mode > should build successfully
  • 404 Page Support SSG > server mode > should respond to 404 correctly
  • 404 Page Support SSG > server mode > should render error correctly
  • 404 Page Support SSG > server mode > should not show an error in the logs for 404 SSG
  • 404 Page Support SSG > server mode > should render index page normal
  • 404 Page Support SSG > server mode > should not revalidate custom 404 page
  • 404 Page Support SSG > server mode > should set pages404 in routes-manifest correctly
  • 404 Page Support SSG > server mode > should have 404 page in prerender-manifest
  • 404 Page Support SSG > serverless mode > should build successfully
  • 404 Page Support SSG > serverless mode > should respond to 404 correctly
  • 404 Page Support SSG > serverless mode > should render error correctly
  • 404 Page Support SSG > serverless mode > should not show an error in the logs for 404 SSG
  • 404 Page Support SSG > serverless mode > should render index page normal
  • 404 Page Support SSG > serverless mode > should not revalidate custom 404 page
  • 404 Page Support SSG > serverless mode > should set pages404 in routes-manifest correctly
  • 404 Page Support SSG > serverless mode > should have 404 page in prerender-manifest
Expand output

● 404 Page Support SSG › server mode › should build successfully

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/BUILD_ID'

● 404 Page Support SSG › server mode › should respond to 404 correctly

FetchError: request to http://localhost:45469/404 failed, reason: connect ECONNREFUSED 127.0.0.1:45469

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › server mode › should render error correctly

FetchError: request to http://localhost:45469/err failed, reason: connect ECONNREFUSED 127.0.0.1:45469

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › server mode › should not show an error in the logs for 404 SSG

FetchError: request to http://localhost:45469/non-existent failed, reason: connect ECONNREFUSED 127.0.0.1:45469

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › server mode › should render index page normal

FetchError: request to http://localhost:45469/ failed, reason: connect ECONNREFUSED 127.0.0.1:45469

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › server mode › should not revalidate custom 404 page

FetchError: request to http://localhost:45469/non-existent failed, reason: connect ECONNREFUSED 127.0.0.1:45469

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › server mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/routes-manifest.json'

● 404 Page Support SSG › server mode › should have 404 page in prerender-manifest

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/prerender-manifest.json'

● 404 Page Support SSG › serverless mode › should build successfully

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/BUILD_ID'

● 404 Page Support SSG › serverless mode › should respond to 404 correctly

FetchError: request to http://localhost:33731/404 failed, reason: connect ECONNREFUSED 127.0.0.1:33731

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › serverless mode › should render error correctly

FetchError: request to http://localhost:33731/err failed, reason: connect ECONNREFUSED 127.0.0.1:33731

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › serverless mode › should not show an error in the logs for 404 SSG

FetchError: request to http://localhost:33731/non-existent failed, reason: connect ECONNREFUSED 127.0.0.1:33731

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › serverless mode › should render index page normal

FetchError: request to http://localhost:33731/ failed, reason: connect ECONNREFUSED 127.0.0.1:33731

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › serverless mode › should not revalidate custom 404 page

FetchError: request to http://localhost:33731/non-existent failed, reason: connect ECONNREFUSED 127.0.0.1:33731

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › serverless mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/routes-manifest.json'

● 404 Page Support SSG › serverless mode › should have 404 page in prerender-manifest

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-ssg/.next/prerender-manifest.json'

● 404 Page Support SSG › dev mode › should respond to 404 correctly

FetchError: request to http://localhost:45221/404 failed, reason: connect ECONNREFUSED 127.0.0.1:45221

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › dev mode › should render error correctly

FetchError: request to http://localhost:45221/err failed, reason: connect ECONNREFUSED 127.0.0.1:45221

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › dev mode › should not show an error in the logs for 404 SSG

FetchError: request to http://localhost:45221/non-existent failed, reason: connect ECONNREFUSED 127.0.0.1:45221

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● 404 Page Support SSG › dev mode › should render index page normal

FetchError: request to http://localhost:45221/ failed, reason: connect ECONNREFUSED 127.0.0.1:45221

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-ssg/test/index.test.js:83:20

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-ssg/test/index.test.js:121:13

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-ssg/test/index.test.js:176:20

test/integration/404-page-custom-error/test/index.test.js

  • Default 404 Page with custom _error > dev mode > should respond to 404 correctly
  • Default 404 Page with custom _error > dev mode > should render error correctly
  • Default 404 Page with custom _error > dev mode > should render index page normal
  • Default 404 Page with custom _error > server mode > should respond to 404 correctly
  • Default 404 Page with custom _error > server mode > should render error correctly
  • Default 404 Page with custom _error > server mode > should render index page normal
  • Default 404 Page with custom _error > server mode > should set pages404 in routes-manifest correctly
  • Default 404 Page with custom _error > server mode > should have output 404.html
  • Default 404 Page with custom _error > serverless mode > should respond to 404 correctly
  • Default 404 Page with custom _error > serverless mode > should render error correctly
  • Default 404 Page with custom _error > serverless mode > should render index page normal
  • Default 404 Page with custom _error > serverless mode > should set pages404 in routes-manifest correctly
  • Default 404 Page with custom _error > serverless mode > should have output 404.html
Expand output

● Default 404 Page with custom _error › server mode › should respond to 404 correctly

FetchError: request to http://localhost:34223/404 failed, reason: connect ECONNREFUSED 127.0.0.1:34223

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › server mode › should render error correctly

FetchError: request to http://localhost:34223/err failed, reason: connect ECONNREFUSED 127.0.0.1:34223

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › server mode › should render index page normal

FetchError: request to http://localhost:34223/ failed, reason: connect ECONNREFUSED 127.0.0.1:34223

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › server mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/routes-manifest.json'

● Default 404 Page with custom _error › server mode › should have output 404.html

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/serverless/pages-manifest.json'

  507 | 
  508 | function readJson(path) {
> 509 |   return JSON.parse(readFileSync(path))
      |                     ^
  510 | }
  511 | 
  512 | export function getBuildManifest(dir) {

  at readJson (lib/next-test-utils.js:509:21)
  at getPagesManifest (lib/next-test-utils.js:546:10)
  at getPageFileFromPagesManifest (lib/next-test-utils.js:550:25)
  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:50:20)

● Default 404 Page with custom _error › serverless mode › should respond to 404 correctly

FetchError: request to http://localhost:39563/404 failed, reason: connect ECONNREFUSED 127.0.0.1:39563

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › serverless mode › should render error correctly

FetchError: request to http://localhost:39563/err failed, reason: connect ECONNREFUSED 127.0.0.1:39563

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › serverless mode › should render index page normal

FetchError: request to http://localhost:39563/ failed, reason: connect ECONNREFUSED 127.0.0.1:39563

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › serverless mode › should set pages404 in routes-manifest correctly

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/routes-manifest.json'

● Default 404 Page with custom _error › serverless mode › should have output 404.html

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/integration/404-page-custom-error/.next/serverless/pages-manifest.json'

  507 | 
  508 | function readJson(path) {
> 509 |   return JSON.parse(readFileSync(path))
      |                     ^
  510 | }
  511 | 
  512 | export function getBuildManifest(dir) {

  at readJson (lib/next-test-utils.js:509:21)
  at getPagesManifest (lib/next-test-utils.js:546:10)
  at getPageFileFromPagesManifest (lib/next-test-utils.js:550:25)
  at Object.<anonymous> (integration/404-page-custom-error/test/index.test.js:50:20)

● Default 404 Page with custom _error › dev mode › should respond to 404 correctly

FetchError: request to http://localhost:46505/404 failed, reason: connect ECONNREFUSED 127.0.0.1:46505

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › dev mode › should render error correctly

FetchError: request to http://localhost:46505/err failed, reason: connect ECONNREFUSED 127.0.0.1:46505

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Default 404 Page with custom _error › dev mode › should render index page normal

FetchError: request to http://localhost:46505/ failed, reason: connect ECONNREFUSED 127.0.0.1:46505

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-custom-error/test/index.test.js:58:20

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-custom-error/test/index.test.js:79:13

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/404-page-custom-error/test/index.test.js:108:20

test/integration/app-document/test/index.test.js

  • Document and App > should not have any missing key warnings
  • Document and App > Client side > should detect the changes to pages/_app.js and display it
  • Document and App > Client side > should detect the changes to pages/_document.js and display it
  • Document and App > Client side > should keep state between page navigations
  • Document and App > Client side > It should share module state with pages
  • Document and App > Rendering via HTTP > _app > It shows a custom tag
  • Document and App > Rendering via HTTP > _app > It should share module state with pages
  • Document and App > Rendering via HTTP > _app > It should show valid error when thrown in _app getInitialProps
  • Document and App > Rendering via HTTP > _document > It has a custom html class
  • Document and App > Rendering via HTTP > _document > It has a custom body class
  • Document and App > Rendering via HTTP > _document > It injects custom head tags
  • Document and App > Rendering via HTTP > _document > It passes props from Document.getInitialProps to Document
  • Document and App > Rendering via HTTP > _document > It adds nonces to all scripts and preload links
  • Document and App > Rendering via HTTP > _document > It adds crossOrigin to all scripts and preload links
  • Document and App > Rendering via HTTP > _document > It renders ctx.renderPage with enhancer correctly
  • Document and App > Rendering via HTTP > _document > It renders ctx.renderPage with enhanceComponent correctly
  • Document and App > Rendering via HTTP > _document > It renders ctx.renderPage with enhanceApp correctly
  • Document and App > Rendering via HTTP > _document > It renders ctx.renderPage with enhanceApp and enhanceComponent correctly
  • Document and App > Rendering via HTTP > _document > It adds a timestamp to link tags with preload attribute to invalidate the cache (DEV only)
  • Document and App > With CSP enabled > should load inline script by hash
  • Document and App > With CSP enabled > should load inline script by nonce
Expand output

● Document and App › should not have any missing key warnings

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It has a custom html class

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It has a custom body class

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It injects custom head tags

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It passes props from Document.getInitialProps to Document

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It adds nonces to all scripts and preload links

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It adds crossOrigin to all scripts and preload links

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhancer correctly

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceComponent correctly

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceApp correctly

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It renders ctx.renderPage with enhanceApp and enhanceComponent correctly

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _document › It adds a timestamp to link tags with preload attribute to invalidate the cache (DEV only)

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _app › It shows a custom tag

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _app › It should share module state with pages

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Rendering via HTTP › _app › It should show valid error when thrown in _app getInitialProps

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Client side › should detect the changes to pages/_app.js and display it

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Client side › should detect the changes to pages/_document.js and display it

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Client side › should keep state between page navigations

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › Client side › It should share module state with pages

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › With CSP enabled › should load inline script by hash

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Document and App › With CSP enabled › should load inline script by nonce

FetchError: request to http://localhost:38427/ failed, reason: connect ECONNREFUSED 127.0.0.1:38427

  at ClientRequest.<anonymous> (../node_modules/node-fetch/lib/index.js:1461:11)

● Test suite failed to run

TypeError: Cannot read property 'pid' of undefined

  281 | export async function killApp(instance) {
  282 |   await new Promise((resolve, reject) => {
> 283 |     treeKill(instance.pid, (err) => {
      |                       ^
  284 |       if (err) {
  285 |         if (
  286 |           process.platform === 'win32' &&

  at lib/next-test-utils.js:283:23
  at killApp (lib/next-test-utils.js:282:9)
  at integration/app-document/test/index.test.js:37:18

test/unit/webpack-config-overrides.unit.test.js

Expand output

● Test suite failed to run

Cannot find module 'next/dist/compiled/resolve/index.js' from 'resolve-request.js'

However, Jest was able to find:
	'./resolve-request.d.ts'
	'./resolve-request.js'
	'./resolve-request.js.map'

You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'json', 'jsx', 'ts', 'tsx', 'node'].

See https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

However, Jest was able to find:
	'../lib/get-package-version.d.ts'
	'../lib/get-package-version.js'
	'../lib/get-package-version.js.map'

You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'json', 'jsx', 'ts', 'tsx', 'node'].

See https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

> 1 | import resolve from 'next/dist/compiled/resolve/index.js'
    | ^
  2 | import path from 'path'
  3 | 
  4 | export function resolveRequest(req: string, issuer: string): string {

  at Resolver.resolveModule (../node_modules/jest-resolve/build/index.js:259:17)
  at Object.<anonymous> (../packages/next/lib/resolve-request.ts:1:1)

@vercel vercel bot temporarily deployed to Preview Nov 25, 2020 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 25, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 8.8s 8.9s ⚠️ +146ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.003 2.031 ⚠️ +0.03
/ avg req/sec 1248.1 1230.89 ⚠️ -17.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.093 1.164 ⚠️ +0.07
/error-in-render avg req/sec 2287.08 2148.08 ⚠️ -139
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 10.8s 10.3s -471ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 915 kB 915 kB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 915 kB 915 kB
link.js 973 kB 973 kB
routerDirect.js 966 kB 966 kB
withRouter.js 966 kB 966 kB
Overall change 4.74 MB 4.74 MB
Commit: def3d74

@vercel vercel bot temporarily deployed to Preview Nov 25, 2020 Inactive
@guybedford
Copy link
Contributor

guybedford commented Nov 25, 2020

@merceyz could you rather remove the rebase of this to #17606 so that we can go ahead with merging?

@ijjk
Copy link
Member

ijjk commented Nov 25, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 9.4s 9.6s ⚠️ +243ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.128 2.099 -0.03
/ avg req/sec 1174.83 1191.09 +16.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.2 1.208 ⚠️ +0.01
/error-in-render avg req/sec 2082.79 2070.28 ⚠️ -12.51
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 11.3s 11.2s -101ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 915 kB 915 kB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 915 kB 915 kB
link.js 973 kB 973 kB
routerDirect.js 966 kB 966 kB
withRouter.js 966 kB 966 kB
Overall change 4.74 MB 4.74 MB
Commit: 5bd0590

@merceyz
Copy link
Contributor Author

merceyz commented Nov 25, 2020

@merceyz could you rather remove the rebase of this to #17606 so that we can go ahead with merging?

I can but it will be without a test

@vercel vercel bot temporarily deployed to Preview Nov 25, 2020 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 25, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 8.5s 8.9s ⚠️ +349ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 1.919 1.96 ⚠️ +0.04
/ avg req/sec 1302.8 1275.79 ⚠️ -27.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.166 1.124 -0.04
/error-in-render avg req/sec 2144.82 2223.61 +78.79
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 10s 10.1s ⚠️ +101ms
nodeModulesSize 84.9 MB 85.1 MB ⚠️ +136 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 59 kB 59 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-b618194..5477.js gzip 1.61 kB 1.61 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 8.01 kB 8.01 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 915 kB 915 kB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 915 kB 915 kB
link.js 973 kB 973 kB
routerDirect.js 966 kB 966 kB
withRouter.js 966 kB 966 kB
Overall change 4.74 MB 4.74 MB
Commit: a37a132

@guybedford
Copy link
Contributor

guybedford commented Nov 25, 2020

I can but it will be without a test

That would be fine, if the test is covered by the other PR.

It could also be nice to include the babel runtime revert here as well.

@merceyz
Copy link
Contributor Author

merceyz commented Nov 25, 2020

That would be fine, if the test is covered by the other PR.

I respectfully disagree, I could however remove the peer dependencies from this PR and keep the test to then rebase the other PR if it isn't merged first

It could also be nice to include the babel runtime revert here as well.

Fixed in #19538 as they aren't really related

@ijjk
Copy link
Member

ijjk commented Jan 9, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 8.7s 8.6s -103ms
nodeModulesSize 80.8 MB 80.8 MB -5.66 kB
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 1.741 1.679 -0.06
/ avg req/sec 1435.96 1488.84 +52.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.069 1.086 ⚠️ +0.02
/error-in-render avg req/sec 2337.64 2301.81 ⚠️ -35.83
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 10.4s 10.2s -298ms
nodeModulesSize 80.8 MB 80.8 MB -15.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 796f7f1

@merceyz merceyz changed the title fix(next): don't ncc resolve perf(next): use require.resolve instead of resolve Jan 9, 2021
basedir: dir,
preserveSymlinks: true,
}),
require.resolve(path.join(name, 'package.json'), { paths: [dir] }),
Copy link
Contributor Author

@merceyz merceyz Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wont preserve the symlink but hopefully that's fine

@merceyz merceyz force-pushed the merceyz/resolve branch 2 times, most recently from 2b6c752 to 2d8bb78 Compare Jan 9, 2021
@ijjk
Copy link
Member

ijjk commented Jan 9, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 10.4s 10.3s -97ms
nodeModulesSize 80.8 MB 80.8 MB -15.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.049 2.076 ⚠️ +0.03
/ avg req/sec 1220.32 1204.27 ⚠️ -16.05
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.323 1.299 -0.02
/error-in-render avg req/sec 1889.3 1924.44 +35.14
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 12.5s 12.4s -102ms
nodeModulesSize 80.8 MB 80.8 MB -15.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 2d8bb78

@timneutkens
Copy link
Member

timneutkens commented Jan 11, 2021

Amazing work @merceyz 💯

@ijjk
Copy link
Member

ijjk commented Jan 11, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 10.5s 10.6s ⚠️ +189ms
nodeModulesSize 80.9 MB 80.8 MB -15.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
/ failed reqs 0 0
/ total time (seconds) 2.136 2.155 ⚠️ +0.02
/ avg req/sec 1170.17 1160.27 ⚠️ -9.9
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.344 1.299 -0.05
/error-in-render avg req/sec 1860.25 1925.14 +64.89
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9769710..cf61.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/resolve Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary merceyz/next.js merceyz/resolve Change
buildDuration 12.3s 12.3s ⚠️ +10ms
nodeModulesSize 80.9 MB 80.8 MB -15.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9769710..cf61.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/resolve Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/resolve Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 238d019

@kodiakhq kodiakhq bot merged commit 1c75bf7 into vercel:canary Jan 11, 2021
26 of 28 checks passed
@merceyz merceyz deleted the merceyz/resolve branch Jan 11, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants