Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra redirect for index with i18n #20397

Merged
merged 5 commits into from
Dec 22, 2020
Merged

Remove extra redirect for index with i18n #20397

merged 5 commits into from
Dec 22, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 22, 2020

This makes sure redirects to the index route properly end with a trailing slash or don't based on the trailingSlash config to ensure an additional redirect doesn't need to take place un-necessarily.

Fixes: #19405

@vercel vercel bot temporarily deployed to Preview December 22, 2020 15:34 Inactive
Timer
Timer previously approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ijjk
Copy link
Member Author

ijjk commented Dec 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
buildDuration 9s 8.9s -143ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +264 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.761 1.742 -0.02
/ avg req/sec 1419.52 1434.83 +15.31
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.124 1.092 -0.03
/error-in-render avg req/sec 2223.26 2289.4 +66.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-abf8a5b..ea50.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
index.html gzip 612 B 612 B ✓
link.html gzip 617 B 617 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
buildDuration 10.7s 10.3s -356ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +264 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-abf8a5b..ea50.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_error.js 1 MB 1 MB ⚠️ +46 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +46 B
link.js 1.06 MB 1.06 MB ⚠️ +46 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +46 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +46 B
Overall change 5.16 MB 5.16 MB ⚠️ +230 B
Commit: efc9769

@vercel vercel bot temporarily deployed to Preview December 22, 2020 15:43 Inactive
@ijjk

This comment has been minimized.

Sign in to view
@vercel vercel bot temporarily deployed to Preview December 22, 2020 16:48 Inactive
@ijjk ijjk requested a review from Timer December 22, 2020 16:49
@ijjk
Copy link
Member Author

ijjk commented Dec 22, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
buildDuration 11.2s 11.4s ⚠️ +118ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +264 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.218 2.303 ⚠️ +0.08
/ avg req/sec 1127.12 1085.41 ⚠️ -41.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.639 1.719 ⚠️ +0.08
/error-in-render avg req/sec 1525.33 1454.31 ⚠️ -71.02
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b7e5569..0ca9.js gzip 6.55 kB 6.55 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
index.html gzip 612 B 612 B ✓
link.html gzip 618 B 618 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
buildDuration 13.1s 13.4s ⚠️ +280ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +264 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b7e5569..0ca9.js gzip 6.55 kB 6.55 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/rm-extra-redirect Change
_error.js 1 MB 1 MB ⚠️ +46 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +46 B
link.js 1.06 MB 1.06 MB ⚠️ +46 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +46 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +46 B
Overall change 5.16 MB 5.16 MB ⚠️ +230 B
Commit: 9afee57

@kodiakhq kodiakhq bot merged commit 118588b into vercel:canary Dec 22, 2020
@Timer Timer deleted the i18n/rm-extra-redirect branch December 22, 2020 17:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[i18n + redirects] unnecessary redirect for index page
2 participants
@ijjk @Timer