Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deploy button URL #20756

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Updated deploy button URL #20756

merged 3 commits into from
Jan 5, 2021

Conversation

rootedsoftware
Copy link

Deploy button doesn't currently deploy this example, let's fix that.

@ijjk ijjk added the examples Issue/PR related to examples label Jan 4, 2021
@ijjk
Copy link
Member

ijjk commented Jan 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary c316/next.js patch-1 Change
buildDuration 10.5s 10.9s ⚠️ +353ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary c316/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.099 2.051 -0.05
/ avg req/sec 1190.82 1219.18 +28.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.351 1.321 -0.03
/error-in-render avg req/sec 1850.05 1891.82 +41.77
Client Bundles (main, webpack, commons)
vercel/next.js canary c316/next.js patch-1 Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary c316/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary c316/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary c316/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary c316/next.js patch-1 Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary c316/next.js patch-1 Change
buildDuration 12.8s 12.5s -259ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary c316/next.js patch-1 Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary c316/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary c316/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary c316/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary c316/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: a5e3d51

lfades
lfades requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c316 Hi there 👋 and thank you for the PR!

Can you also update the deploy button at the bottom of the readme 🙏

@rootedsoftware
Copy link
Author

@lfades Woops, missed that one. Yes, I just changed that as well.

@ijjk
Copy link
Member

ijjk commented Jan 5, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary c316/next.js patch-1 Change
buildDuration 10.4s 10.5s ⚠️ +55ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary c316/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.054 2.049 0
/ avg req/sec 1216.87 1219.96 +3.09
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.329 ⚠️ +0.07
/error-in-render avg req/sec 1984.23 1881.08 ⚠️ -103.15
Client Bundles (main, webpack, commons)
vercel/next.js canary c316/next.js patch-1 Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary c316/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary c316/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary c316/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary c316/next.js patch-1 Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary c316/next.js patch-1 Change
buildDuration 13.2s 12.5s -658ms
nodeModulesSize 80.6 MB 80.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary c316/next.js patch-1 Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6b712d3..3360.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary c316/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary c316/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary c316/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary c316/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: ae96e9a

lfades
lfades approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lfades lfades merged commit 51f2a53 into vercel:canary Jan 5, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rootedsoftware @ijjk @lfades