Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected dependencies for preact and inferno #2583

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Tom910
Copy link
Contributor

@Tom910 Tom910 commented Jul 17, 2017

I received the following errors

{ Error: Cannot find module 'react/dist/react.min.js'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.resolve (internal/module.js:18:19)
    at _callee2$ (/Users/a.marchenko/Downloads/using-preact/node_modules/next/dist/server/build/webpack.js:516:34)
    at tryCatch (/Users/a.marchenko/Downloads/using-preact/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/Users/a.marchenko/Downloads/using-preact/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/Users/a.marchenko/Downloads/using-preact/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/Users/a.marchenko/Downloads/using-preact/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /Users/a.marchenko/Downloads/using-preact/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at Promise (<anonymous>)
    at F (/Users/a.marchenko/Downloads/using-preact/node_modules/core-js/library/modules/_export.js:35:28) code: 'MODULE_NOT_FOUND' }

The build requires React

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Jul 18, 2017

Unfortunately this has to be done like this right now. @arunoda for some reason Travis failed without logs. Could you merge this.

@Tom910
Copy link
Contributor Author

@Tom910 Tom910 commented Aug 7, 2017

@timneutkens @arunoda Will merged this pr?

@timneutkens timneutkens merged commit b664908 into vercel:master Sep 8, 2017
2 of 3 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants