From 12fb75540d93c5b553e6f596b33fffcaeb4466a6 Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Thu, 10 Jun 2021 17:32:34 +0200 Subject: [PATCH 01/13] fix: client-side navigation when redirecting to a rewriten URL --- .../next/next-server/lib/router/router.ts | 7 ++- .../next.config.js | 10 ++++ .../pages/some-other-page.js | 16 ++++++ .../pages/some-page.js | 21 +++++++ .../test/index.test.js | 57 +++++++++++++++++++ 5 files changed, 110 insertions(+), 1 deletion(-) create mode 100644 test/integration/redirect-getserversideprops-rewrites/next.config.js create mode 100644 test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js create mode 100644 test/integration/redirect-getserversideprops-rewrites/pages/some-page.js create mode 100644 test/integration/redirect-getserversideprops-rewrites/test/index.test.js diff --git a/packages/next/next-server/lib/router/router.ts b/packages/next/next-server/lib/router/router.ts index 276765dc604e6..faebf7bbddb54 100644 --- a/packages/next/next-server/lib/router/router.ts +++ b/packages/next/next-server/lib/router/router.ts @@ -1112,7 +1112,12 @@ export default class Router implements BaseRouter { pages ) - if (pages.includes(parsedHref.pathname)) { + const isDestinationAKnownPage = pages.includes(parsedHref.pathname) + const isDestinationARewrittenUrl = rewrites.afterFiles.some( + (x: any) => x.source === parsedHref.pathname + ) + + if (isDestinationAKnownPage || isDestinationARewrittenUrl) { const { url: newUrl, as: newAs } = prepareUrlAs( this, destination, diff --git a/test/integration/redirect-getserversideprops-rewrites/next.config.js b/test/integration/redirect-getserversideprops-rewrites/next.config.js new file mode 100644 index 0000000000000..c699245c9e240 --- /dev/null +++ b/test/integration/redirect-getserversideprops-rewrites/next.config.js @@ -0,0 +1,10 @@ +module.exports = { + async rewrites() { + return [ + { + source: '/', + destination: '/some-page', + }, + ] + }, +} diff --git a/test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js b/test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js new file mode 100644 index 0000000000000..61e0ade5e3b24 --- /dev/null +++ b/test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js @@ -0,0 +1,16 @@ +export default function SomeOtherPage() { + return ( +
+

Hello world

+
+ ) +} + +export const getServerSideProps = ({ query }) => { + return { + redirect: { + destination: `${query.redirect}?message=${query.message}`, + permanent: false, + }, + } +} diff --git a/test/integration/redirect-getserversideprops-rewrites/pages/some-page.js b/test/integration/redirect-getserversideprops-rewrites/pages/some-page.js new file mode 100644 index 0000000000000..4f9af04dc9474 --- /dev/null +++ b/test/integration/redirect-getserversideprops-rewrites/pages/some-page.js @@ -0,0 +1,21 @@ +import Link from 'next/link' + +export default function SomePage({ message }) { + return ( +
+

Hello {message}

+ + + Link with rewritten target url + + + + Link with client side navigation + +
+ ) +} + +export const getServerSideProps = ({ query }) => ({ + props: { message: query.message || 'World ' }, +}) diff --git a/test/integration/redirect-getserversideprops-rewrites/test/index.test.js b/test/integration/redirect-getserversideprops-rewrites/test/index.test.js new file mode 100644 index 0000000000000..163d13503918e --- /dev/null +++ b/test/integration/redirect-getserversideprops-rewrites/test/index.test.js @@ -0,0 +1,57 @@ +/* eslint-env jest */ + +import { join } from 'path' +import { + renderViaHTTP, + findPort, + launchApp, + killApp, + waitFor, +} from 'next-test-utils' +import webdriver from 'next-webdriver' + +// test suites + +const context = {} +jest.setTimeout(1000 * 60 * 5) + +describe('getServerSideProps redirects', () => { + beforeAll(async () => { + context.appPort = await findPort() + context.server = await launchApp(join(__dirname, '../'), context.appPort, { + env: { __NEXT_TEST_WITH_DEVTOOL: 1 }, + }) + + // pre-build all pages at the start + await Promise.all([ + renderViaHTTP(context.appPort, '/'), + renderViaHTTP(context.appPort, '/some-page'), + ]) + }) + afterAll(() => killApp(context.server)) + + it('should use a client-side navigation for a rewritten URL', async () => { + const browser = await webdriver(context.appPort, '/') + + await browser.executeScript(function () { + // During a browser navigation global variables are reset, + // So by chaking that the __SAME_PAGE variable is still defined + // then the client-side navigation has happened + window.__SAME_PAGE = true + }) + + await browser.elementByCss('#link-with-rewritten-url').click() + + // Wait for a potential page reload + await waitFor(1000) + + // Wait until the new props are rendered + await browser.elementByCss('.refreshed') + + const isSamePage = await browser.executeScript(function () { + return window.__SAME_PAGE || false + }) + + expect(isSamePage).toBe(true) + }) +}) From 066846c894207f446068a8ff33707dae40b5dfb8 Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Sun, 13 Jun 2021 11:22:09 +0200 Subject: [PATCH 02/13] refactor: move gssp redirect with rewrites tests next to gssp-redirect folder --- examples/with-mdx-remote/README.md | 2 +- .../next.config.js | 4 ++-- .../pages/main-content.js} | 6 +++--- .../pages/redirector.js} | 2 +- .../test/index.test.js | 6 +++--- 5 files changed, 10 insertions(+), 10 deletions(-) rename test/integration/{redirect-getserversideprops-rewrites => gssp-redirect-with-rewrites}/next.config.js (50%) rename test/integration/{redirect-getserversideprops-rewrites/pages/some-page.js => gssp-redirect-with-rewrites/pages/main-content.js} (63%) rename test/integration/{redirect-getserversideprops-rewrites/pages/some-other-page.js => gssp-redirect-with-rewrites/pages/redirector.js} (85%) rename test/integration/{redirect-getserversideprops-rewrites => gssp-redirect-with-rewrites}/test/index.test.js (87%) diff --git a/examples/with-mdx-remote/README.md b/examples/with-mdx-remote/README.md index 8c08583dfb38e..e4a8338410ff5 100644 --- a/examples/with-mdx-remote/README.md +++ b/examples/with-mdx-remote/README.md @@ -40,7 +40,7 @@ const SomeHeavyComponent = dynamic(() => import('SomeHeavyComponent')) const defaultComponents = { Test } -export function SomePage({ mdxSource, componentNames }) { +export function Page2({ mdxSource, componentNames }) { const components = { ...defaultComponents, SomeHeavyComponent: componentNames.includes('SomeHeavyComponent') diff --git a/test/integration/redirect-getserversideprops-rewrites/next.config.js b/test/integration/gssp-redirect-with-rewrites/next.config.js similarity index 50% rename from test/integration/redirect-getserversideprops-rewrites/next.config.js rename to test/integration/gssp-redirect-with-rewrites/next.config.js index c699245c9e240..5ceb9cf1250a7 100644 --- a/test/integration/redirect-getserversideprops-rewrites/next.config.js +++ b/test/integration/gssp-redirect-with-rewrites/next.config.js @@ -2,8 +2,8 @@ module.exports = { async rewrites() { return [ { - source: '/', - destination: '/some-page', + source: '/alias-to-main-content', + destination: '/main-content', }, ] }, diff --git a/test/integration/redirect-getserversideprops-rewrites/pages/some-page.js b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js similarity index 63% rename from test/integration/redirect-getserversideprops-rewrites/pages/some-page.js rename to test/integration/gssp-redirect-with-rewrites/pages/main-content.js index 4f9af04dc9474..d8307e9e82542 100644 --- a/test/integration/redirect-getserversideprops-rewrites/pages/some-page.js +++ b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js @@ -1,15 +1,15 @@ import Link from 'next/link' -export default function SomePage({ message }) { +export default function MainContent({ message }) { return (

Hello {message}

- + Link with rewritten target url - + Link with client side navigation
diff --git a/test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js b/test/integration/gssp-redirect-with-rewrites/pages/redirector.js similarity index 85% rename from test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js rename to test/integration/gssp-redirect-with-rewrites/pages/redirector.js index 61e0ade5e3b24..f955aadb8f725 100644 --- a/test/integration/redirect-getserversideprops-rewrites/pages/some-other-page.js +++ b/test/integration/gssp-redirect-with-rewrites/pages/redirector.js @@ -1,4 +1,4 @@ -export default function SomeOtherPage() { +export default function Redirector() { return (

Hello world

diff --git a/test/integration/redirect-getserversideprops-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js similarity index 87% rename from test/integration/redirect-getserversideprops-rewrites/test/index.test.js rename to test/integration/gssp-redirect-with-rewrites/test/index.test.js index 163d13503918e..9b96941d5e425 100644 --- a/test/integration/redirect-getserversideprops-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -24,14 +24,14 @@ describe('getServerSideProps redirects', () => { // pre-build all pages at the start await Promise.all([ - renderViaHTTP(context.appPort, '/'), - renderViaHTTP(context.appPort, '/some-page'), + renderViaHTTP(context.appPort, '/alias-to-main-content'), + renderViaHTTP(context.appPort, '/main-content'), ]) }) afterAll(() => killApp(context.server)) it('should use a client-side navigation for a rewritten URL', async () => { - const browser = await webdriver(context.appPort, '/') + const browser = await webdriver(context.appPort, '/alias-to-main-content') await browser.executeScript(function () { // During a browser navigation global variables are reset, From 658b9d6be09987c2bb44d260ea561ab0b2a5fcc2 Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Mon, 14 Jun 2021 11:39:01 +0200 Subject: [PATCH 03/13] revert: component name in documentation updated while refactoring --- examples/with-mdx-remote/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/with-mdx-remote/README.md b/examples/with-mdx-remote/README.md index e4a8338410ff5..8c08583dfb38e 100644 --- a/examples/with-mdx-remote/README.md +++ b/examples/with-mdx-remote/README.md @@ -40,7 +40,7 @@ const SomeHeavyComponent = dynamic(() => import('SomeHeavyComponent')) const defaultComponents = { Test } -export function Page2({ mdxSource, componentNames }) { +export function SomePage({ mdxSource, componentNames }) { const components = { ...defaultComponents, SomeHeavyComponent: componentNames.includes('SomeHeavyComponent') From 94c2fa8a58e214a47fd59dd87fc14a154cde725f Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 11:14:53 +0200 Subject: [PATCH 04/13] reove check known route as there is a fallback anyway --- .../next/next-server/lib/router/router.ts | 17 ++++------- .../pages/main-content.js | 30 ++++++++++++++----- 2 files changed, 27 insertions(+), 20 deletions(-) diff --git a/packages/next/next-server/lib/router/router.ts b/packages/next/next-server/lib/router/router.ts index faebf7bbddb54..75ac430c4cf11 100644 --- a/packages/next/next-server/lib/router/router.ts +++ b/packages/next/next-server/lib/router/router.ts @@ -1112,19 +1112,12 @@ export default class Router implements BaseRouter { pages ) - const isDestinationAKnownPage = pages.includes(parsedHref.pathname) - const isDestinationARewrittenUrl = rewrites.afterFiles.some( - (x: any) => x.source === parsedHref.pathname + const { url: newUrl, as: newAs } = prepareUrlAs( + this, + destination, + destination ) - - if (isDestinationAKnownPage || isDestinationARewrittenUrl) { - const { url: newUrl, as: newAs } = prepareUrlAs( - this, - destination, - destination - ) - return this.change(method, newUrl, newAs, options) - } + return this.change(method, newUrl, newAs, options) } window.location.href = destination diff --git a/test/integration/gssp-redirect-with-rewrites/pages/main-content.js b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js index d8307e9e82542..9a807242ad489 100644 --- a/test/integration/gssp-redirect-with-rewrites/pages/main-content.js +++ b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js @@ -4,14 +4,28 @@ export default function MainContent({ message }) { return (

Hello {message}

- - - Link with rewritten target url - - - - Link with client side navigation - + +
) } From b1e8c77c31518293f0d201c8931270750054ba89 Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:34:02 +0200 Subject: [PATCH 05/13] update build output size --- test/integration/build-output/test/index.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/build-output/test/index.test.js b/test/integration/build-output/test/index.test.js index 5b5e04ebb0c0d..1791315a26131 100644 --- a/test/integration/build-output/test/index.test.js +++ b/test/integration/build-output/test/index.test.js @@ -129,7 +129,7 @@ describe('Build Output', () => { expect(parseFloat(err404Size)).toBeCloseTo(gz ? 3.17 : 8.51, 1) expect(err404Size.endsWith('kB')).toBe(true) - expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.9 : 205, 1) + expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.9 : 204, 1) expect(err404FirstLoad.endsWith('kB')).toBe(true) expect(parseFloat(sharedByAll)).toBeCloseTo(gz ? 63.7 : 196, 1) From 31c46a0fafd8c0a170a098c36b6c6b20fd11b71a Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:34:33 +0200 Subject: [PATCH 06/13] Update test/integration/gssp-redirect-with-rewrites/test/index.test.js Co-authored-by: JJ Kasper --- .../gssp-redirect-with-rewrites/test/index.test.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index 9b96941d5e425..0c7b887ef8f0d 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -42,11 +42,8 @@ describe('getServerSideProps redirects', () => { await browser.elementByCss('#link-with-rewritten-url').click() - // Wait for a potential page reload - await waitFor(1000) - // Wait until the new props are rendered - await browser.elementByCss('.refreshed') + await browser.waitForElementByCss('.refreshed') const isSamePage = await browser.executeScript(function () { return window.__SAME_PAGE || false From 682935be094de4d1817ef151045f3296542b8cfe Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:35:06 +0200 Subject: [PATCH 07/13] Update test/integration/gssp-redirect-with-rewrites/test/index.test.js Co-authored-by: JJ Kasper --- .../gssp-redirect-with-rewrites/test/index.test.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index 0c7b887ef8f0d..7591f83b0ad03 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -45,10 +45,6 @@ describe('getServerSideProps redirects', () => { // Wait until the new props are rendered await browser.waitForElementByCss('.refreshed') - const isSamePage = await browser.executeScript(function () { - return window.__SAME_PAGE || false - }) - - expect(isSamePage).toBe(true) + expect(await browser.eval('window.__SAME_PAGE')).toBe(true) }) }) From 9a85b5699554d16742f4fcac18c378bf62c3d8cc Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:35:17 +0200 Subject: [PATCH 08/13] Update test/integration/gssp-redirect-with-rewrites/test/index.test.js Co-authored-by: JJ Kasper --- .../gssp-redirect-with-rewrites/test/index.test.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index 7591f83b0ad03..eccae32fdc95d 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -33,12 +33,10 @@ describe('getServerSideProps redirects', () => { it('should use a client-side navigation for a rewritten URL', async () => { const browser = await webdriver(context.appPort, '/alias-to-main-content') - await browser.executeScript(function () { - // During a browser navigation global variables are reset, - // So by chaking that the __SAME_PAGE variable is still defined - // then the client-side navigation has happened - window.__SAME_PAGE = true - }) + // During a browser navigation global variables are reset, + // So by chaking that the __SAME_PAGE variable is still defined + // then the client-side navigation has happened + await browser.eval('window.__SAME_PAGE = true') await browser.elementByCss('#link-with-rewritten-url').click() From 954429415311cf53e835be96b9697e93e71d4f5f Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:36:14 +0200 Subject: [PATCH 09/13] fix typo --- test/integration/gssp-redirect-with-rewrites/test/index.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index eccae32fdc95d..a34713f833687 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -34,7 +34,7 @@ describe('getServerSideProps redirects', () => { const browser = await webdriver(context.appPort, '/alias-to-main-content') // During a browser navigation global variables are reset, - // So by chaking that the __SAME_PAGE variable is still defined + // So by checking that the __SAME_PAGE variable is still defined // then the client-side navigation has happened await browser.eval('window.__SAME_PAGE = true') From 8823e06190c6084822bc906f841383f3019aa35a Mon Sep 17 00:00:00 2001 From: Antoine Chalifour Date: Tue, 15 Jun 2021 16:49:35 +0200 Subject: [PATCH 10/13] add test for redirects to unknown route --- .../pages/main-content.js | 4 ++-- .../test/index.test.js | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/test/integration/gssp-redirect-with-rewrites/pages/main-content.js b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js index 9a807242ad489..5a3af8bc2a15b 100644 --- a/test/integration/gssp-redirect-with-rewrites/pages/main-content.js +++ b/test/integration/gssp-redirect-with-rewrites/pages/main-content.js @@ -21,8 +21,8 @@ export default function MainContent({ message }) {
  • - - Link to unknown internal navigation + + Link to unknown internal navigation
  • diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index a34713f833687..bf075d1e2dbaf 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -45,4 +45,19 @@ describe('getServerSideProps redirects', () => { expect(await browser.eval('window.__SAME_PAGE')).toBe(true) }) + + it('should fallback to browser navigation for an unknown URL', async () => { + const browser = await webdriver(context.appPort, '/alias-to-main-content') + + // then the client-side navigation has happened + await browser.eval('window.__SAME_PAGE = true') + + await browser.elementByCss('#link-unknown-url').click() + + // Wait until the page has be reloaded + await waitFor(1000) + await browser.elementById('__next') + + expect(await browser.eval('window.__SAME_PAGE')).toBeNull() + }) }) From fd722c47df4defc146fa2f96c31d769d8358c390 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 16 Jun 2021 13:45:56 -0500 Subject: [PATCH 11/13] update size test --- test/integration/build-output/test/index.test.js | 2 +- .../gssp-redirect-with-rewrites/test/index.test.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/integration/build-output/test/index.test.js b/test/integration/build-output/test/index.test.js index 1791315a26131..5893d7aa14569 100644 --- a/test/integration/build-output/test/index.test.js +++ b/test/integration/build-output/test/index.test.js @@ -149,7 +149,7 @@ describe('Build Output', () => { true ) - expect(parseFloat(mainSize)).toBeCloseTo(gz ? 20.1 : 62.8, 1) + expect(parseFloat(mainSize)).toBeCloseTo(gz ? 20.1 : 62.7, 1) expect(mainSize.endsWith('kB')).toBe(true) expect(parseFloat(frameworkSize)).toBeCloseTo(gz ? 42.0 : 130, 1) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index bf075d1e2dbaf..f7e8d9197838a 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -7,6 +7,7 @@ import { launchApp, killApp, waitFor, + check, } from 'next-test-utils' import webdriver from 'next-webdriver' @@ -51,13 +52,12 @@ describe('getServerSideProps redirects', () => { // then the client-side navigation has happened await browser.eval('window.__SAME_PAGE = true') - await browser.elementByCss('#link-unknown-url').click() // Wait until the page has be reloaded - await waitFor(1000) - await browser.elementById('__next') - - expect(await browser.eval('window.__SAME_PAGE')).toBeNull() + await check(async () => { + const val = await browser.eval('window.__SAME_PAGE') + return val ? 'fail' : 'success' + }, 'success') }) }) From ab5954d0bf67acf8f8ad395d85619e510cd5cd17 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 16 Jun 2021 13:59:12 -0500 Subject: [PATCH 12/13] Update test --- test/integration/gssp-redirect-base-path/test/index.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/gssp-redirect-base-path/test/index.test.js b/test/integration/gssp-redirect-base-path/test/index.test.js index cf38969fda73a..77cb9eff390fd 100644 --- a/test/integration/gssp-redirect-base-path/test/index.test.js +++ b/test/integration/gssp-redirect-base-path/test/index.test.js @@ -204,7 +204,7 @@ const runTests = (isDev) => { const curUrl = await browser.url() const { pathname } = url.parse(curUrl) - expect(pathname).toBe('/missing') + expect(pathname).toBe('/docs/missing') }) it('should apply redirect when fallback GSP page is visited directly (external domain)', async () => { From f932956cfcfc9ab6f7c141d364cbc36267df2228 Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 16 Jun 2021 14:14:08 -0500 Subject: [PATCH 13/13] lint-fix --- test/integration/gssp-redirect-with-rewrites/test/index.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/integration/gssp-redirect-with-rewrites/test/index.test.js b/test/integration/gssp-redirect-with-rewrites/test/index.test.js index f7e8d9197838a..392ced7b1b5ff 100644 --- a/test/integration/gssp-redirect-with-rewrites/test/index.test.js +++ b/test/integration/gssp-redirect-with-rewrites/test/index.test.js @@ -6,7 +6,6 @@ import { findPort, launchApp, killApp, - waitFor, check, } from 'next-test-utils' import webdriver from 'next-webdriver'