Use named functions in layouts docs#27297
Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom Jul 19, 2021
samrobbins85:canary
Merged
Use named functions in layouts docs#27297kodiakhq[bot] merged 2 commits intovercel:canaryfrom samrobbins85:canary
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
samrobbins85:canary
Conversation
samrobbins85
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
1 task
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
## Documentation / Examples - [x] Make sure the linting passes Fixes vercel#27252 by using a named function rather than an arrow function. If this is the correct fix, then modifications are also needed for the `layout-component` example, but I'm just providing this one modification right now in case this fix is incorrect.
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
## Documentation / Examples - [x] Make sure the linting passes In line with the PR vercel#27297 which solved issue vercel#27252, this updates the example to also use named functions in order to pass ESLint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
Fixes #27252 by using a named function rather than an arrow function. If this is the correct fix, then modifications are also needed for the
layout-componentexample, but I'm just providing this one modification right now in case this fix is incorrect.