Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a shared worker pool for collecting page data and static page generation #27924

Merged
merged 8 commits into from Aug 12, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 10, 2021

this avoid loading all code twice and hopefully improving performance

errors/manifest.json Outdated Show resolved Hide resolved
@sokra sokra force-pushed the perf/shared-static-worker-pool branch from 0d7b22d to cba88fd Compare Aug 10, 2021
@ijjk

This comment has been minimized.

@sokra sokra requested a review from ijjk Aug 10, 2021
@sokra sokra force-pushed the perf/shared-static-worker-pool branch from 614bf80 to cc8c84c Compare Aug 10, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

ijjk
ijjk approved these changes Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Failing test suites

Commit: 167bc27

test/acceptance/ReactRefreshLogBox.dev.test.js

  • server-side only compilation errors

Expand output

● server-side only compilation errors

ScriptTimeoutError: script timeout
  (Session info: headless chrome=92.0.4515.131)

  72 |
  73 |             // Wait for application to re-hydrate:
> 74 |             await browser.executeAsyncScript(function () {
     |             ^
  75 |               var callback = arguments[arguments.length - 1]
  76 |               if (window.__NEXT_HYDRATED) {
  77 |                 callback()

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
      at runMicrotasks (<anonymous>)
  at Proxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.patch (acceptance/helpers.js:74:13)
  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:1422:3)

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
buildDuration 14.3s 14.2s -100ms
buildDurationCached 3.4s 3.2s -167ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +6.06 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
/ failed reqs 0 0
/ total time (seconds) 2.557 2.583 ⚠️ +0.03
/ avg req/sec 977.56 967.74 ⚠️ -9.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.368 1.47 ⚠️ +0.1
/error-in-render avg req/sec 1827.83 1701.01 ⚠️ -126.82
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
buildDuration 11.7s 11.9s ⚠️ +242ms
buildDurationCached 4.7s 4.7s -15ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +6.06 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
/ failed reqs 0 0
/ total time (seconds) 2.544 2.606 ⚠️ +0.06
/ avg req/sec 982.68 959.41 ⚠️ -23.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.432 1.489 ⚠️ +0.06
/error-in-render avg req/sec 1746.13 1679.21 ⚠️ -66.92
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js perf/shared-static-worker-pool Change
index.html gzip 577 B 577 B
link.html gzip 590 B 590 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 6487d28

@kodiakhq kodiakhq bot merged commit 8bbb1cd into canary Aug 12, 2021
31 checks passed
@kodiakhq kodiakhq bot deleted the perf/shared-static-worker-pool branch Aug 12, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants