Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update util to 0.12.4 #27939

Merged
merged 4 commits into from Aug 14, 2021
Merged

Update util to 0.12.4 #27939

merged 4 commits into from Aug 14, 2021

Conversation

agektmr
Copy link
Contributor

@agektmr agektmr commented Aug 11, 2021

Chrome 92 started to disable SharedArrayBuffer without cross-origin isolation which can be enabled by sending the page with special HTTP headers. This change causes Chrome to emit a warning in DevTools console and developers are confused with the message. util is one of the libraries that uses SharedArrayBuffer and is causing the warning to appear in the console.

Luckily, the issue in util has been resolved in [v0.12.4] and I would like to propose applying the fixed version to this library.

For fixing #21708

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Chrome 92 started to disable `SharedArrayBuffer` without cross-origin isolation which can be enabled by sending [the page with special HTTP headers](https://web.dev/cross-origin-isolation-guide/). This change causes Chrome to emit a warning in DevTools console and [developers are confused with the message](vercel#21708). `util` is one of the libraries that uses `SharedArrayBuffer` and is causing the warning to appear in the console.

Luckily, the issue in `util` has been resolved in [v0.12.4] and I would like to propose applying the fixed version to this library.

For fixing vercel#21708
@ijjk

This comment has been minimized.

styfle
styfle approved these changes Aug 13, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 13, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary agektmr/next.js patch-1 Change
buildDuration 10.1s 10.3s ⚠️ +161ms
buildDurationCached 2.6s 2.6s ⚠️ +5ms
nodeModulesSize 49.1 MB 49.1 MB -34.8 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary agektmr/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.008 2.016 ⚠️ +0.01
/ avg req/sec 1245.04 1239.95 ⚠️ -5.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.104 1.105 0
/error-in-render avg req/sec 2265.43 2262.88 ⚠️ -2.55
Client Bundles (main, webpack, commons)
vercel/next.js canary agektmr/next.js patch-1 Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary agektmr/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary agektmr/next.js patch-1 Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary agektmr/next.js patch-1 Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary agektmr/next.js patch-1 Change
index.html gzip 541 B 541 B
link.html gzip 553 B 553 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary agektmr/next.js patch-1 Change
buildDuration 8.6s 8.6s -38ms
buildDurationCached 3.5s 3.5s -46ms
nodeModulesSize 49.1 MB 49.1 MB -34.8 kB
Page Load Tests Overall increase ✓
vercel/next.js canary agektmr/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.08 2.081 0
/ avg req/sec 1201.77 1201.41 ⚠️ -0.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.222 1.15 -0.07
/error-in-render avg req/sec 2046.37 2173.21 +126.84
Client Bundles (main, webpack, commons)
vercel/next.js canary agektmr/next.js patch-1 Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary agektmr/next.js patch-1 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary agektmr/next.js patch-1 Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary agektmr/next.js patch-1 Change
_buildManifest.js gzip 497 B 497 B
Overall change 497 B 497 B
Rendered Page Sizes
vercel/next.js canary agektmr/next.js patch-1 Change
index.html gzip 585 B 585 B
link.html gzip 598 B 598 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: e0dc7c7

@kodiakhq kodiakhq bot merged commit 73b5d69 into vercel:canary Aug 14, 2021
31 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants