Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image optimization encoding url #28045

Merged
merged 12 commits into from Aug 13, 2021
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 12, 2021

The problem with PR #27671 is that it was encoding too often when it really only needed to solve the bug for next build && next start since next dev was already working.

This PR uses the alternative solution mentioned here #27210 (comment)

ijjk
ijjk previously approved these changes Aug 12, 2021
Copy link
Member

@ijjk ijjk left a comment

Good catch!

@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as draft Aug 12, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as ready for review Aug 12, 2021
@ijjk

This comment has been minimized.

@styfle styfle requested a review from ijjk Aug 12, 2021
styfle and others added 2 commits Aug 12, 2021
@styfle styfle requested a review from ijjk Aug 12, 2021
ijjk
ijjk previously approved these changes Aug 12, 2021
@ijjk

This comment has been minimized.

@styfle styfle marked this pull request as draft Aug 12, 2021
shuding
shuding previously approved these changes Aug 12, 2021
@styfle styfle dismissed stale reviews from shuding and ijjk via 9136c59 Aug 12, 2021
@styfle styfle marked this pull request as ready for review Aug 12, 2021
@styfle styfle requested a review from ijjk Aug 12, 2021
@ijjk

This comment has been minimized.

@styfle styfle requested a review from ijjk Aug 12, 2021
ijjk
ijjk previously approved these changes Aug 12, 2021
@ijjk

This comment has been minimized.

@styfle styfle requested review from ijjk and shuding Aug 12, 2021
ijjk
ijjk approved these changes Aug 12, 2021
@ijjk
Copy link
Member

ijjk commented Aug 13, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
buildDuration 13.8s 13.8s -3ms
buildDurationCached 3.4s 3.2s -219ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +648 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
/ failed reqs 0 0
/ total time (seconds) 2.638 2.61 -0.03
/ avg req/sec 947.84 957.83 +9.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.746 1.669 -0.08
/error-in-render avg req/sec 1431.99 1498.22 +66.23
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
buildDuration 11.7s 11.8s ⚠️ +85ms
buildDurationCached 4.5s 4.3s -169ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +648 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
/ failed reqs 0 0
/ total time (seconds) 2.69 2.655 -0.04
/ avg req/sec 929.35 941.58 +12.23
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.652 1.608 -0.04
/error-in-render avg req/sec 1513 1554.62 +41.62
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-unicode-and-url-encoding Change
index.html gzip 576 B 576 B
link.html gzip 590 B 590 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: 9ce365e

@kodiakhq kodiakhq bot merged commit b11bd49 into canary Aug 13, 2021
31 checks passed
@kodiakhq kodiakhq bot deleted the fix-unicode-and-url-encoding branch Aug 13, 2021
@stefanprobst
Copy link
Contributor

stefanprobst commented Aug 13, 2021

thanks for fixing what i messed up 😬

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"url" parameter is valid but upstream response is invalid — next/image on 11.1
4 participants