Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @next scope for native packages #28046

Merged
merged 1 commit into from Aug 12, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Aug 12, 2021

Use @next npm scope to avoid triggering spam detection

@@ -1,5 +1,5 @@
{
"name": "next-swc-linux-x64-gnu",
"name": "@next/swc-linux-x64-gnu",
Copy link
Member

@ijjk ijjk Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we initialize these packages on npm already with 0.0.0?

Copy link
Member Author

@padmaia padmaia Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ,0.0.0 is more of a placeholder as the versions get overwritten in the publish-native.js script. The updated versions are not being committed at the moment because it seemed kind of weird to commit it after the tag, but let me know if you have other ideas.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary padmaia/next.js scope-native-packages Change
buildDuration 13.6s 13.5s -137ms
buildDurationCached 3.2s 3.1s -57ms
nodeModulesSize 49.1 MB 49.1 MB -2 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js scope-native-packages Change
/ failed reqs 0 0
/ total time (seconds) 2.497 2.458 -0.04
/ avg req/sec 1001 1017.14 +16.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.45 1.403 -0.05
/error-in-render avg req/sec 1724.47 1782.32 +57.85
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js scope-native-packages Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.5 kB 1.5 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js scope-native-packages Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary padmaia/next.js scope-native-packages Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.8 kB 12.8 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js scope-native-packages Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js scope-native-packages Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary padmaia/next.js scope-native-packages Change
buildDuration 11.3s 11.1s -161ms
buildDurationCached 4.4s 4.5s ⚠️ +132ms
nodeModulesSize 49.1 MB 49.1 MB -2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js scope-native-packages Change
/ failed reqs 0 0
/ total time (seconds) 2.495 2.517 ⚠️ +0.02
/ avg req/sec 1002.19 993.17 ⚠️ -9.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.401 1.4 0
/error-in-render avg req/sec 1784.43 1785.72 +1.29
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js scope-native-packages Change
17.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js scope-native-packages Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary padmaia/next.js scope-native-packages Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.7 kB 17.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js scope-native-packages Change
_buildManifest.js gzip 498 B 498 B
Overall change 498 B 498 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js scope-native-packages Change
index.html gzip 577 B 577 B
link.html gzip 590 B 590 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: f4b7179

ijjk
ijjk approved these changes Aug 12, 2021
@padmaia padmaia merged commit ff5e444 into vercel:canary Aug 12, 2021
25 of 27 checks passed
continue
}
let binaryName = `next-swc.${nativePackage.substr(9)}.node`
let platforms = await (await readdir(nativePackagesDir)).filter(
Copy link
Member

@styfle styfle Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the outside await is not necessary here since filter() is not async

Copy link
Member Author

@padmaia padmaia Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, not sure what happened there

@padmaia padmaia deleted the scope-native-packages branch Sep 15, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants