Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revalidate for initial notFound: true paths #28097

Merged
merged 2 commits into from Aug 14, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 14, 2021

This fixes revalidation not occurring correctly when notFound: true is returned during build, additional tests have been added to ensure this is working correctly for dynamic and non-dynamic pages returning notFound: true during build and then revalidating afterwards.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #21453

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 14, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Aug 14, 2021
@ijjk
Copy link
Member Author

ijjk commented Aug 14, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
buildDuration 13.5s 13.6s ⚠️ +36ms
buildDurationCached 3.4s 3.3s -46ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +484 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
/ failed reqs 0 0
/ total time (seconds) 2.636 2.614 -0.02
/ avg req/sec 948.29 956.21 +7.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.434 1.468 ⚠️ +0.03
/error-in-render avg req/sec 1742.82 1702.54 ⚠️ -40.28
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.1 kB 23.1 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67 kB 67 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
_app-HASH.js gzip 980 B 980 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.64 kB 2.64 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 904 B 904 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
buildDuration 11.1s 11.1s -1ms
buildDurationCached 4.6s 4.6s -28ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +484 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
/ failed reqs 0 0
/ total time (seconds) 2.689 2.669 -0.02
/ avg req/sec 929.74 936.82 +7.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.468 1.422 -0.05
/error-in-render avg req/sec 1702.78 1757.83 +55.05
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14 kB 14 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
_app-HASH.js gzip 965 B 965 B
_error-HASH.js gzip 3.71 kB 3.71 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.83 kB 2.83 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.95 kB 2.95 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.8 kB 17.8 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
_buildManifest.js gzip 497 B 497 B
Overall change 497 B 497 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/initial-not-found Change
index.html gzip 585 B 585 B
link.html gzip 598 B 598 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: e83e9f7

@kodiakhq kodiakhq bot merged commit 1697852 into vercel:canary Aug 14, 2021
27 of 29 checks passed
@ijjk ijjk deleted the fix/initial-not-found branch Aug 14, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetStaticProps returning initial notFound never triggers a rebuild on revalidate with dynamic routes
2 participants