Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place 'charset' element at the top of <head> #28119

Merged
merged 3 commits into from Feb 6, 2022
Merged

Conversation

Ryz0nd
Copy link
Contributor

@Ryz0nd Ryz0nd commented Aug 14, 2021

Bug

fixes: #26534
I'm sorry. I know there are people assigned to this issue, but I wanted to solve this issue as soon as possible.

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@Ryz0nd Ryz0nd closed this Aug 29, 2021
Copy link
Member

@styfle styfle left a comment

@Ryz0nd This looks good. Any reason why you closed it?

@Ryz0nd
Copy link
Contributor Author

@Ryz0nd Ryz0nd commented Sep 8, 2021

@styfle I just thought this issue had been forgotten. Thank you for your review!

@Ryz0nd Ryz0nd reopened this Sep 8, 2021
styfle
styfle previously approved these changes Sep 8, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

Copy link
Member

@timneutkens timneutkens left a comment

This needs a review from @janicklas-ralph

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@janicklas-ralph
Copy link
Collaborator

@janicklas-ralph janicklas-ralph commented Sep 8, 2021

Added a comment. We might still encounter the issue with this fix.

@janicklas-ralph
Copy link
Collaborator

@janicklas-ralph janicklas-ralph commented Sep 13, 2021

I slightly misunderstood the requirement here. If we only care about <meta charset> being on top then this should work.

@valoricDe
Copy link

@valoricDe valoricDe commented Oct 12, 2021

@janicklas-ralph do you know where this test error originates from
https://github.com/vercel/next.js/pull/28119/checks?check_run_id=3547125652
syntax error .button { missing closing block.
I don't think it comes from the change in here, does it?

@valoricDe
Copy link

@valoricDe valoricDe commented Oct 12, 2021

So in general we have possibly defined charset meta tags in next/component head or in document head.
It seems we currently only collect and dedupe meta charsets from next/head (#27142)
If one would define charsets in both places we should probably show a warning right?

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk added the area: examples label Feb 5, 2022
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

@ijjk ijjk commented Feb 6, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Ryz0nd/next.js charset-first Change
buildDuration 15.5s 15.4s -68ms
buildDurationCached 6s 6s -39ms
nodeModulesSize 359 MB 359 MB -14 B
Page Load Tests Overall increase ✓
vercel/next.js canary Ryz0nd/next.js charset-first Change
/ failed reqs 0 0
/ total time (seconds) 3.169 3.061 -0.11
/ avg req/sec 788.79 816.7 +27.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.322 1.333 ⚠️ +0.01
/error-in-render avg req/sec 1891.13 1875.1 ⚠️ -16.03
Client Bundles (main, webpack, commons)
vercel/next.js canary Ryz0nd/next.js charset-first Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Ryz0nd/next.js charset-first Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Ryz0nd/next.js charset-first Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary Ryz0nd/next.js charset-first Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary Ryz0nd/next.js charset-first Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Ryz0nd/next.js charset-first Change
buildDuration 19s 18.8s -162ms
buildDurationCached 6s 6s ⚠️ +82ms
nodeModulesSize 359 MB 359 MB -14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Ryz0nd/next.js charset-first Change
/ failed reqs 0 0
/ total time (seconds) 3.16 3.121 -0.04
/ avg req/sec 791.23 800.92 +9.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.316 1.343 ⚠️ +0.03
/error-in-render avg req/sec 1899.78 1861.32 ⚠️ -38.46
Client Bundles (main, webpack, commons)
vercel/next.js canary Ryz0nd/next.js charset-first Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Ryz0nd/next.js charset-first Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary Ryz0nd/next.js charset-first Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.21 kB 2.21 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.3 kB 14.3 kB
Client Build Manifests
vercel/next.js canary Ryz0nd/next.js charset-first Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary Ryz0nd/next.js charset-first Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 5502a5d

ijjk
ijjk approved these changes Feb 6, 2022
Copy link
Member

@ijjk ijjk left a comment

Change looks good and as mentioned above seems to not cause any conflict, thanks for the PR!

@ijjk ijjk merged commit 6090101 into vercel:canary Feb 6, 2022
42 checks passed
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@ChaeMingyun
Copy link

@ChaeMingyun ChaeMingyun commented Feb 17, 2022

Looks good!

@balazsorban44 balazsorban44 mentioned this pull request Feb 28, 2022
1 task
@TheThirdRace
Copy link

@TheThirdRace TheThirdRace commented Mar 5, 2022

@Ryz0nd
Would it be possible to check this out again.

I just tried and, while the situation "improved", charset is still only the second from the top.

<head>
    <meta name="viewport" content="width=device-width">
    <meta charset="utf-8">

I don't set the charset or the viewport meta tags myself, I let NextJs create it for me.

I did try setting them following the example in the PR, but the result was a lot worst as both were way down in the <head>

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants