Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relationship between issuer and module to traces #28192

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Aug 17, 2021

Sets the parent span for module traces to the module that caused this current module to compile, this makes tracing why a module was compiled much simpler. Also added NEXT_WEBPACK_PARALLELISM to allow for better traces of individual modules, this should only be used in combination with tracing. Also added webpack-close which fills the time that was not traced previous.

New trace chart from Jaeger, previously this would be flat:

Screen Shot 2021-08-17 at 12 21 44

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Sets the parent span for module traces to the module that caused this current module to compile, this makes tracing why a module was compiled much simpler. Also added `NEXT_WEBPACK_PARALLELISM` to allow for better traces of individual modules, this should only be used in combination with tracing.
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

styfle
styfle previously approved these changes Aug 17, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 17, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
buildDuration 13.3s 13.6s ⚠️ +307ms
buildDurationCached 3.5s 3.3s -140ms
nodeModulesSize 61.5 MB 61.5 MB ⚠️ +995 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
/ failed reqs 0 0
/ total time (seconds) 2.415 2.451 ⚠️ +0.04
/ avg req/sec 1035.33 1019.87 ⚠️ -15.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.332 1.353 ⚠️ +0.02
/error-in-render avg req/sec 1877.48 1848.33 ⚠️ -29.15
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.65 kB 2.65 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.13 kB 4.13 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 12.9 kB 12.9 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
buildDuration 11.2s 11.3s ⚠️ +53ms
buildDurationCached 4.6s 4.6s ⚠️ +44ms
nodeModulesSize 61.5 MB 61.5 MB ⚠️ +995 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
/ failed reqs 0 0
/ total time (seconds) 2.466 2.518 ⚠️ +0.05
/ avg req/sec 1013.81 993.04 ⚠️ -20.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.353 1.395 ⚠️ +0.04
/error-in-render avg req/sec 1847.56 1791.71 ⚠️ -55.85
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.85 kB 2.85 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
_buildManifest.js gzip 499 B 499 B
Overall change 499 B 499 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/tracing-module-relationships Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: a279dc9

@timneutkens timneutkens merged commit e920dbc into vercel:canary Aug 18, 2021
31 of 33 checks passed
@timneutkens timneutkens deleted the add/tracing-module-relationships branch Aug 18, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants