Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure adding _app/_document HMRs correctly #28279

Merged
merged 3 commits into from Aug 19, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 19, 2021

This is a follow-up to #28227 to ensure _app and _document HMR correctly when you start the dev server and then add _app and _document.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: #27888

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 19, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 19, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
buildDuration 14.9s 15.1s ⚠️ +162ms
buildDurationCached 3.8s 3.5s -279ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +653 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
/ failed reqs 0 0
/ total time (seconds) 2.706 2.591 -0.11
/ avg req/sec 923.9 964.9 +41
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.485 1.426 -0.06
/error-in-render avg req/sec 1683.79 1752.58 +68.79
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
buildDuration 12.4s 12.3s -90ms
buildDurationCached 5.1s 5.1s ⚠️ +80ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +653 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
/ failed reqs 0 0
/ total time (seconds) 2.724 2.664 -0.06
/ avg req/sec 917.64 938.26 +20.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.576 1.486 -0.09
/error-in-render avg req/sec 1586.01 1682.85 +96.84
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js more/hmr-app-document Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: b24ec0b

@ijjk ijjk marked this pull request as ready for review Aug 19, 2021
@kodiakhq kodiakhq bot merged commit 9b09b92 into vercel:canary Aug 19, 2021
32 checks passed
@ijjk ijjk deleted the more/hmr-app-document branch Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants