Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Adds process.exit to next lint success output #28299

Merged
merged 2 commits into from Aug 19, 2021
Merged

[ESLint] Adds process.exit to next lint success output #28299

merged 2 commits into from Aug 19, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Aug 19, 2021

This PR ensures that next lint always exits after the process is complete. This fixes #28194.

styfle
styfle approved these changes Aug 19, 2021
@ijjk
Copy link
Member

ijjk commented Aug 19, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
buildDuration 12.8s 12.8s ⚠️ +50ms
buildDurationCached 3.3s 3.3s -31ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +48 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
/ failed reqs 0 0
/ total time (seconds) 2.317 2.293 -0.02
/ avg req/sec 1079.1 1090.24 +11.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.249 1.265 ⚠️ +0.02
/error-in-render avg req/sec 2002.09 1975.65 ⚠️ -26.44
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 535 B 535 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
buildDuration 10.7s 10.8s ⚠️ +73ms
buildDurationCached 4.5s 4.4s -146ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +48 B
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
/ failed reqs 0 0
/ total time (seconds) 2.347 2.316 -0.03
/ avg req/sec 1065.15 1079.54 +14.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.262 1.267 0
/error-in-render avg req/sec 1981.08 1973.12 ⚠️ -7.96
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js bug/#28194 Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 6d4bb46

ijjk
ijjk approved these changes Aug 19, 2021
@kodiakhq kodiakhq bot merged commit 4e76911 into vercel:canary Aug 19, 2021
32 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab CI timeout in "next lint" with Next.js 11.1.0
3 participants