Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next env vars injection in dynamic #28309

Merged
merged 3 commits into from Aug 20, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 19, 2021

  • Treat next/dynamic as non external modules
  • add feature flags to webpack cache version

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

lfades
lfades approved these changes Aug 19, 2021
Copy link
Member

@lfades lfades left a comment

LGTM

styfle
styfle approved these changes Aug 19, 2021
ijjk
ijjk approved these changes Aug 19, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 19, 2021

Failing test suites

Commit: defe400

test/integration/image-component/default/test/index.test.js

  • Image Component Tests > dev mode > should warn when img with layout=fill is inside a container without position relative
Expand output

● Image Component Tests › dev mode › should warn when img with layout=fill is inside a container without position relative

expect(received).toMatch(expected)

Expected pattern: /Image with src (.*)jpg(.*) may not render properly with a parent using position:\\"static\\". Consider changing the parent style to position:\\"relative\\"/gm
Received string:  ""

  605 |         .join('\n')
  606 |       expect(await hasRedbox(browser)).toBe(false)
> 607 |       expect(warnings).toMatch(
      |                        ^
  608 |         /Image with src (.*)jpg(.*) may not render properly with a parent using position:\\"static\\". Consider changing the parent style to position:\\"relative\\"/gm
  609 |       )
  610 |     })

  at Object.<anonymous> (integration/image-component/default/test/index.test.js:607:24)

test/acceptance/ReactRefreshLogBox.dev.test.js

  • logbox: can recover from a syntax error without losing state

Expand output

● logbox: can recover from a syntax error without losing state

expect(received).toBe(expected) // Object.is equality

Expected: "Count: 1"
Received: "1"

  61 |   expect(
  62 |     await session.evaluate(() => document.querySelector('p').textContent)
> 63 |   ).toBe('Count: 1')
     |     ^
  64 |
  65 |   expect(await session.hasRedbox()).toBe(false)
  66 |

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:63:5)

@ijjk
Copy link
Member

ijjk commented Aug 20, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
buildDuration 13s 12.8s -196ms
buildDurationCached 4.5s 3.2s -1.2s
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +342 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
/ failed reqs 0 0
/ total time (seconds) 2.355 2.383 ⚠️ +0.03
/ avg req/sec 1061.55 1049.11 ⚠️ -12.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.337 1.295 -0.04
/error-in-render avg req/sec 1869.39 1931 +61.61
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.2 kB 23.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
index.html gzip 541 B 541 B
link.html gzip 553 B 553 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
buildDuration 10.8s 10.7s -37ms
buildDurationCached 4.4s 4.5s ⚠️ +27ms
nodeModulesSize 61.4 MB 61.4 MB ⚠️ +342 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
/ failed reqs 0 0
/ total time (seconds) 2.356 2.379 ⚠️ +0.02
/ avg req/sec 1061.25 1050.85 ⚠️ -10.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.29 1.315 ⚠️ +0.02
/error-in-render avg req/sec 1938.29 1901.77 ⚠️ -36.52
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 2.98 kB 2.98 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-dynamic-bundle Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 577 B 577 B
Overall change 1.76 kB 1.76 kB
Commit: ba3b8ed

@kodiakhq kodiakhq bot merged commit b74ffff into vercel:canary Aug 20, 2021
30 of 32 checks passed
@huozhi huozhi deleted the fix-dynamic-bundle branch Aug 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants