Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Enable caching by default #28349

Merged
merged 4 commits into from Aug 23, 2021
Merged

[ESLint] Enable caching by default #28349

merged 4 commits into from Aug 23, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Aug 20, 2021

This PR enables ESLint caching by default to improve linting performance. The cache is written to .next/cache (or the user defined custom build directory):

Screen Shot 2021-08-20 at 5 27 33 PM

Note: With this PR, ESLint caching will be automatically enabled when run during next build and next lint, but users have the option to opt-out by running next lint --no-cache.

@@ -61,7 +61,8 @@ const nextLint: cliCommand = async (argv) => {
'--max-warnings': Number,
'--no-inline-config': Boolean,
'--report-unused-disable-directives': String,
'--cache': Boolean,
'--cache': Boolean, // Although cache is enabled by default, this dummy flag still exists to not cause any breaking changes
Copy link
Collaborator Author

@housseindjirdeh housseindjirdeh Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many users likely opt-in to caching today using next lint --cache. I kept --cache as a dummy flag so it doesn't cause any breaking changes.

@ijjk

This comment has been minimized.

@housseindjirdeh housseindjirdeh marked this pull request as draft Aug 20, 2021
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
@ijjk

This comment has been minimized.

@housseindjirdeh housseindjirdeh marked this pull request as ready for review Aug 20, 2021
@ijjk

This comment has been minimized.

ijjk
ijjk approved these changes Aug 23, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 23, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
buildDuration 16.4s 18.8s ⚠️ +2.4s
buildDurationCached 4s 3.6s -344ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +884 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.25 3.524 ⚠️ +0.27
/ avg req/sec 769.13 709.45 ⚠️ -59.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.012 2.258 ⚠️ +0.25
/error-in-render avg req/sec 1242.76 1107.41 ⚠️ -135.35
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
buildDuration 14.2s 12.8s -1.3s
buildDurationCached 5.8s 5.4s -387ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +884 B
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.254 2.997 -0.26
/ avg req/sec 768.35 834.22 +65.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.935 1.893 -0.04
/error-in-render avg req/sec 1291.71 1320.61 +28.9
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3 kB 3 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
_buildManifest.js gzip 501 B 501 B
Overall change 501 B 501 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint-cache Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 2a1ae1b

@ijjk ijjk merged commit 80921b6 into vercel:canary Aug 23, 2021
32 checks passed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: documentation created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants