Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More elegant application of antd #2840

Merged
merged 9 commits into from Sep 8, 2017
Merged

More elegant application of antd #2840

merged 9 commits into from Sep 8, 2017

Conversation

starriv
Copy link
Contributor

@starriv starriv commented Aug 24, 2017

No description provided.

@ernestofreyreg
Copy link

@ernestofreyreg ernestofreyreg commented Aug 31, 2017

Ant Design is really nice, a very comprehensible collections of components, styles, grids, etc.

The only problem I am seeing is the big >400Kb of css styling the example is downloading from a CDN.

There should be a way to only include in the CSS those styles we need. They recommend using babel-plugin-import

Copy link
Member

@timneutkens timneutkens left a comment

👍

@timneutkens timneutkens merged commit ace748d into vercel:master Sep 8, 2017
2 of 3 checks passed
@ernestofreyreg
Copy link

@ernestofreyreg ernestofreyreg commented Sep 11, 2017

This example is failing due to transform-decorators-legacy is not found.

@BafS
Copy link

@BafS BafS commented Sep 11, 2017

Me too, for the moment I just import the CSS as a string and add it to the JSX.

import antdStyles from 'antd/lib/style/index.css';
import datePickerStyle from 'antd/lib/date-picker/style/index.css';

// ...

<style jsx global>{`
    ${antdStyles}  
    ${datePickerStyle}
    ...
`}</style>

@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants