Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test config to leverage swc #28400

Merged
merged 6 commits into from Aug 23, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 22, 2021

This updates our jest configuration to no longer use babel-jest and instead uses @swc/jest which is much faster. This also updates to the latest version of jest, fixes our tsconfig.json used for tests (previously types in node_modules weren't resolved correctly), and ensures next/dist isn't un-necessarily transpiled in jest.

Timings for yarn testheadless test/unit/ on CI

Timings for yarn testheadless test/unit/ locally on m1 mac

  • before: 90.16 seconds
  • after: 29.92 seconds

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 22, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Aug 22, 2021
styfle
styfle approved these changes Aug 23, 2021
Copy link
Member

@styfle styfle left a comment

Nice work!

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Aug 23, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js tests/update-config Change
buildDuration 15.9s 16.2s ⚠️ +266ms
buildDurationCached 3.6s 3.8s ⚠️ +201ms
nodeModulesSize 61.7 MB 61.7 MB -2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js tests/update-config Change
/ failed reqs 0 0
/ total time (seconds) 2.962 2.969 ⚠️ +0.01
/ avg req/sec 844.01 841.99 ⚠️ -2.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.872 1.907 ⚠️ +0.03
/error-in-render avg req/sec 1335.12 1310.82 ⚠️ -24.3
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/update-config Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.1 kB 67.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/update-config Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/update-config Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/update-config Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/update-config Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js tests/update-config Change
buildDuration 14s 13.7s -293ms
buildDurationCached 5.9s 5.4s -486ms
nodeModulesSize 61.7 MB 61.7 MB -2 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js tests/update-config Change
/ failed reqs 0 0
/ total time (seconds) 3.211 2.928 -0.28
/ avg req/sec 778.54 853.69 +75.15
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.073 1.876 -0.2
/error-in-render avg req/sec 1206 1332.56 +126.56
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js tests/update-config Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.6 kB 10.6 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68 kB 68 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js tests/update-config Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js tests/update-config Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3 kB 3 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js tests/update-config Change
_buildManifest.js gzip 501 B 501 B
Overall change 501 B 501 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js tests/update-config Change
index.html gzip 586 B 586 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 0162c26

@kodiakhq kodiakhq bot merged commit ece79a4 into vercel:canary Aug 23, 2021
32 checks passed
@ijjk ijjk deleted the tests/update-config branch Aug 23, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants