Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error is shown correctly for empty headers field #28430

Merged
merged 3 commits into from Aug 25, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 24, 2021

This ensures we show an error when an empty headers field is passed for a header item correctly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

x-ref: vercel/vercel#6623

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 24, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review Aug 24, 2021
ijjk and others added 2 commits Aug 24, 2021
@ijjk ijjk requested a review from styfle Aug 24, 2021
styfle
styfle approved these changes Aug 24, 2021
Copy link
Member

@styfle styfle left a comment

Thanks!

@ijjk
Copy link
Member Author

ijjk commented Aug 24, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/empty-headers Change
buildDuration 14s 13.7s -245ms
buildDurationCached 3.3s 3.2s -65ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +313 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/empty-headers Change
/ failed reqs 0 0
/ total time (seconds) 2.685 2.455 -0.23
/ avg req/sec 930.96 1018.46 +87.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.471 1.35 -0.12
/error-in-render avg req/sec 1699.38 1851.7 +152.32
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/empty-headers Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/empty-headers Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/empty-headers Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/empty-headers Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/empty-headers Change
index.html gzip 540 B 540 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/empty-headers Change
buildDuration 11.3s 11.3s ⚠️ +28ms
buildDurationCached 4.8s 4.7s -109ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +313 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/empty-headers Change
/ failed reqs 0 0
/ total time (seconds) 2.475 2.445 -0.03
/ avg req/sec 1009.96 1022.47 +12.51
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.377 1.379 0
/error-in-render avg req/sec 1815.12 1813.22 ⚠️ -1.9
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/empty-headers Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/empty-headers Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/empty-headers Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/empty-headers Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/empty-headers Change
index.html gzip 585 B 585 B
link.html gzip 597 B 597 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: 3ff7e8b

This was referenced Sep 3, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants