Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove unnecessary await #28594

Merged
merged 1 commit into from Aug 29, 2021

Conversation

andersonleite
Copy link
Contributor

@andersonleite andersonleite commented Aug 29, 2021

'await' has no effect on the type of this expression.ts(80007)

Bug

  • Integration tests clean up

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Aug 29, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
buildDuration 16.1s 16s -122ms
buildDurationCached 3.7s 3.6s -130ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +3 B
Page Load Tests Overall increase ✓
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
/ failed reqs 0 0
/ total time (seconds) 3.004 2.959 -0.04
/ avg req/sec 832.27 844.83 +12.56
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.95 1.869 -0.08
/error-in-render avg req/sec 1282.02 1337.52 +55.5
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
index.html gzip 541 B 541 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
buildDuration 13.1s 13.3s ⚠️ +175ms
buildDurationCached 5.7s 5.5s -220ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +3 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
/ failed reqs 0 0
/ total time (seconds) 2.977 3.079 ⚠️ +0.1
/ avg req/sec 839.68 812.01 ⚠️ -27.67
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.858 1.843 -0.02
/error-in-render avg req/sec 1345.88 1356.35 +10.47
Client Bundles (main, webpack, commons)
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary andersonleite/next.js remove-unnecessary-await Change
index.html gzip 584 B 584 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: 836a158

@andersonleite andersonleite changed the title Test: Remove unnecessary await Tests: Remove unnecessary await Aug 29, 2021
huozhi
huozhi approved these changes Aug 29, 2021
Copy link
Member

@huozhi huozhi left a comment

Thanks!

@kodiakhq kodiakhq bot merged commit 8711c5c into vercel:canary Aug 29, 2021
32 checks passed
This was referenced Jan 27, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants