Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSP to Image Optimization API #28620

Merged
merged 4 commits into from Aug 30, 2021
Merged

Add CSP to Image Optimization API #28620

merged 4 commits into from Aug 30, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 30, 2021

Add CSP header to Image Optimization API

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 30, 2021
@styfle styfle force-pushed the next-image-csp-header branch from b638509 to 5b95140 Compare Aug 30, 2021
@styfle styfle marked this pull request as ready for review Aug 30, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Aug 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js next-image-csp-header Change
buildDuration 18.5s 18.4s -160ms
buildDurationCached 4.1s 4.2s ⚠️ +31ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +199 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js next-image-csp-header Change
/ failed reqs 0 0
/ total time (seconds) 3.349 3.357 ⚠️ +0.01
/ avg req/sec 746.48 744.7 ⚠️ -1.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.119 2.074 -0.05
/error-in-render avg req/sec 1179.82 1205.18 +25.36
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js next-image-csp-header Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js next-image-csp-header Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js next-image-csp-header Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary vercel/next.js next-image-csp-header Change
_buildManifest.js gzip 491 B 491 B
Overall change 491 B 491 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js next-image-csp-header Change
index.html gzip 541 B 541 B
link.html gzip 552 B 552 B
withRouter.html gzip 534 B 534 B
Overall change 1.63 kB 1.63 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js next-image-csp-header Change
buildDuration 14.9s 15.2s ⚠️ +277ms
buildDurationCached 6.3s 6.4s ⚠️ +44ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +199 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js next-image-csp-header Change
/ failed reqs 0 0
/ total time (seconds) 3.326 3.373 ⚠️ +0.05
/ avg req/sec 751.76 741.28 ⚠️ -10.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.03 2.066 ⚠️ +0.04
/error-in-render avg req/sec 1231.72 1210.21 ⚠️ -21.51
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js next-image-csp-header Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js next-image-csp-header Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js next-image-csp-header Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js next-image-csp-header Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js next-image-csp-header Change
index.html gzip 584 B 584 B
link.html gzip 597 B 597 B
withRouter.html gzip 578 B 578 B
Overall change 1.76 kB 1.76 kB
Commit: ee403b0

@ijjk
Copy link
Member

ijjk commented Aug 30, 2021

Failing test suites

Commit: ee403b0

test/acceptance/ReactRefreshLogBox.dev.test.js

  • component props errors
Expand output

● component props errors

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  845 |   expect(await session.hasRedbox(true)).toBe(true)
  846 |   const source = await session.getRedboxSource()
> 847 |   expect(source).toMatch('./index.module.css:1:1')
      |                                       ^
  848 |   expect(source).toMatch('Syntax error: ')
  849 |   expect(source).toMatch('Unclosed block')
  850 |   expect(source).toMatch('> 1 | .button {')

  at Object.<anonymous> (acceptance/ReactRefreshLogBox.dev.test.js:847:39)

This was referenced Jan 27, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants