Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass conf to export function #2962

Merged
merged 2 commits into from Sep 27, 2017
Merged

Pass conf to export function #2962

merged 2 commits into from Sep 27, 2017

Conversation

hobochild
Copy link
Contributor

@hobochild hobochild commented Sep 17, 2017

Connects to #2954

server/export.js Outdated
@@ -9,9 +9,9 @@ import { renderToHTML } from './render'
import { getAvailableChunks } from './utils'
import { printAndExit } from '../lib/utils'

export default async function (dir, options) {
export default async function (dir, options, conf) {
Copy link
Member

@timneutkens timneutkens Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets call this configuration

Copy link
Contributor Author

@hobochild hobochild Sep 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

Copy link
Member

@timneutkens timneutkens left a comment

Seems alright 👍

cc @arunoda

@timneutkens timneutkens merged commit a50e440 into vercel:master Sep 27, 2017
3 checks passed
@timneutkens
Copy link
Member

@timneutkens timneutkens commented Sep 27, 2017

Thanks!

chuyik pushed a commit to chuyik/next.js that referenced this issue Oct 19, 2017
* Pass conf to export function

* conf -> configuration
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants